Opened 11 years ago

Last modified 3 months ago

#12224 needs_work enhancement

Language as parent / Word as element

Reported by: vdelecroix Owned by: vdelecroix
Priority: major Milestone: sage-wishlist
Component: combinatorics Keywords: word, language, symbolic dynamics
Cc: sstarosta, slabbe, tmonteil, ncohen, tjolivet, jepperlein Merged in:
Authors: Vincent Delecroix Reviewers: Sébastien Labbé
Report Upstream: N/A Work issues: pickling, doctests errors, revert changes on repr, ...
Branch: Commit:
Dependencies: #8920, #12230, #12518, #13778, #13956, #13957, #13801 Stopgaps:

Status badges

Description (last modified by vdelecroix)

This ticket is a prerequisite to further development in the combinatorics of words and symbolic dynamical systems (adic language, SFT, ...). It concerns the implementation of a class "Language" (= graded set of words) as a Parent and a class "Word" as Element.

Three categories are created: Languages, FactorialLanguages and Shifts that gather several methods of finite and infinite words. For speed reason there are base Cython classes for

  • finite word (in sage.combinat.words.finite_word)
  • infinite word (in sage.combinat.words.infinite_word)
  • language (in sage.combinat.languages.language)

Every implementation must inherit from the class above (it is check in the TestSuite? of the related categories).

The previous code of Word is dispatched between the ElementMethods of the category and the Cython class FiniteWord. The choice has been made for sake of optimization.


Old pre-git instructions to import the code. To import and apply all patches do

cd SAGE_ROOT/devel/YOUR_BRANCH
hg qimport http://trac.sagemath.org/sage_trac/raw-attachment/ticket/8920/trac_8920-alphabet.patch
hg qpush
hg qimport http://trac.sagemath.org/sage_trac/raw-attachment/ticket/12466/trac_12466-ss.patch
hg qpush
hg qimport http://trac.sagemath.org/sage_trac/raw-attachment/ticket/12230/trac_12230-growing_letters-ss.patch 
hg qpush
hg qimport http://trac.sagemath.org/sage_trac/raw-attachment/ticket/12230/trac_12230-growing_letters-review-vd.patch
hg qpush
hg qimport http://trac.sagemath.org/sage_trac/raw-attachment/ticket/13801/trac_13801-fix_facade_initialisation-vd.patch
hg qpush
hg qimport http://trac.sagemath.org/sage_trac/raw-attachment/ticket/13956/trac_13956-shift_argument.patch
hg qpush
hg qimport http://trac.sagemath.org/sage_trac/raw-attachment/ticket/13957/trac_13957-catch_value_error.patch 
hg qpush
hg qimport http://trac.sagemath.org/sage_trac/raw-attachment/ticket/12224/trac_12224-language.patch
hg qpush

Attachments (1)

trac_12224-language.patch (1.3 MB) - added by vdelecroix 10 years ago.

Download all attachments as: .zip

Change History (36)

comment:1 Changed 11 years ago by vdelecroix

  • Description modified (diff)

comment:2 Changed 11 years ago by vdelecroix

  • Dependencies set to #10193
  • Description modified (diff)

comment:3 Changed 10 years ago by ncohen

  • Cc ncohen added

comment:4 Changed 10 years ago by vdelecroix

  • Dependencies changed from #10193 to #8920, #10193

comment:5 Changed 10 years ago by vdelecroix

  • Dependencies changed from #8920, #10193 to #8920, #10193, #13803, #13778

comment:6 Changed 10 years ago by vdelecroix

  • Dependencies changed from #8920, #10193, #13803, #13778 to #8920, #13778, #13956

comment:7 Changed 10 years ago by vdelecroix

  • Dependencies changed from #8920, #13778, #13956 to #8920, #13778, #13956, #13957
  • Description modified (diff)

comment:8 Changed 10 years ago by vdelecroix

  • Dependencies changed from #8920, #13778, #13956, #13957 to #8920, #12230, #12518, #13778, #13956, #13957

Changed 10 years ago by vdelecroix

comment:9 Changed 10 years ago by vdelecroix

The patch is still in experimental version but a relatively stable one (all tests pass but the coverage is not 100%)... you may use, test, comment, break and enjoy !

Best, Vincent

comment:10 follow-up: Changed 10 years ago by slabbe

I started the review. Here is a first bunch of comments.

  1. Goal of the ticket: Categories in sage/combinat/words library. The goal of this patch reimplements the code structure of sage/combinat/words using categories. It also adds classes for languages which is a good thing that I would need for my own research. It touches other files outside of this folder. It also depends on some particular tickets fixing bugs in Cython (#13957) and other patches that apply on similar files which do not commute with this huge patch. Moreover since it is a huge patch touching many files, it prevents any user/developper to change any code in sage/combinat/words without creating conflicts. So I hope this will not take forever to get reviewed because meanwhile it prevents the evolution of the actual code.
  1. Content of the patch. It is a huge patch (1.3MG). It modifies 40 files, add 27 files and removes 6 files (see detailed list below). It is hard for any reviewer to make sure he doesn't miss a problem possibly added by the patch. Is there a way to cut the patch in different chunks (tickets) which could make it more easy to get it into Sage because easier for reviewers?
~/Applications/sage-5.6.rc0/devel/sage-language/sage/combinat/words $ hg qtop
trac_12224-language-vd.patch
~/Applications/sage-5.6.rc0/devel/sage-language/sage/combinat/words $ hg qst
M doc/en/reference/categories.rst
M doc/en/reference/combinat/words.rst
M module_list.py
M sage/all.py
M sage/categories/algebras.py
M sage/categories/algebras_with_basis.py
M sage/categories/all.py
M sage/categories/examples/algebras_with_basis.py
M sage/categories/modules_with_basis.py
M sage/categories/primer.py
M sage/categories/rings.py
M sage/categories/sets_cat.py
M sage/combinat/all.py
M sage/combinat/debruijn_sequence.pyx
M sage/combinat/e_one_star.py
M sage/combinat/free_module.py
M sage/combinat/iet/constructors.py
M sage/combinat/iet/labelled.py
M sage/combinat/iet/reduced.py
M sage/combinat/lyndon_word.py
M sage/combinat/ribbon.py
M sage/combinat/ribbon_tableau.py
M sage/combinat/sf/ns_macdonald.py
M sage/combinat/skew_tableau.py
M sage/combinat/tableau.py
M sage/combinat/words/__init__.py
M sage/combinat/words/all.py
M sage/combinat/words/alphabet.py
M sage/combinat/words/morphism.py
M sage/combinat/words/notes/history.txt
M sage/combinat/words/paths.py
M sage/combinat/words/shuffle_product.py
M sage/combinat/words/suffix_trees.py
M sage/combinat/words/word.py
M sage/combinat/words/word_datatypes.pyx
M sage/combinat/words/word_generators.py
M sage/combinat/words/words.py
M sage/graphs/digraph_generators.py
M sage/sets/disjoint_set.pyx
M setup.py
A sage/categories/examples/languages.py
A sage/categories/factorial_languages.py
A sage/categories/languages.py
A sage/categories/shifts.py
A sage/combinat/languages/__init__.py
A sage/combinat/languages/all.py
A sage/combinat/languages/balanced_languages.py
A sage/combinat/languages/base_class.py
A sage/combinat/languages/finite_word_language.py
A sage/combinat/languages/generators.py
A sage/combinat/languages/language.pxd
A sage/combinat/languages/language.pyx
A sage/combinat/words/finite_word.pxd
A sage/combinat/words/finite_word.pyx
A sage/combinat/words/infinite_word.pxd
A sage/combinat/words/infinite_word.pyx
A sage/combinat/words/lazy_word.py
A sage/combinat/words/maps.py
A sage/combinat/words/notes/categorification.txt
A sage/combinat/words/word_datatypes.pxd
A sage/combinat/words/word_deprecation.py
A sage/combinat/words/word_integer.py
A sage/dynamics/__init__.py
A sage/dynamics/all.py
A sage/dynamics/symbolic/__init__.py
A sage/dynamics/symbolic/all.py
A sage/dynamics/symbolic/full_shift.py
R sage/combinat/words/abstract_word.py
R sage/combinat/words/finite_word.py
R sage/combinat/words/infinite_word.py
R sage/combinat/words/notes/word_inheritance_howto.txt
R sage/combinat/words/word_infinite_datatypes.py
R sage/combinat/words/word_options.py
  1. Reject on tableau file. The actual path creates a reject on the tableau file (I am still using the svn directory for the patches. I will test the patch from the ticket instead soon. Maybe that's the reason for the reject.) :
10 slabbe@pol ~/Applications/sage-5.6.rc0/devel/sage-language $ hg qpush -a
applying trac_12466-ss.patch
applying trac_12230-growing_letters-ss.patch
applying trac_12230-growing_letters-review-vd.patch
applying trac_13801-fix_facade_initialisation-vd.patch
applying trac_8920-alphabet-vd.patch
applying trac_13803-limits.patch
applying trac_10962-pickle_set_pythontype.patch
applying trac_13956-shift_argument.patch
applying trac_13957-catch_value_error.patch
applying trac_12224-language-vd.patch
patching file sage/combinat/tableau.py
Hunk #2 FAILED at 434
Hunk #4 FAILED at 584
Hunk #5 FAILED at 2070
3 out of 5 hunks FAILED -- saving rejects to file sage/combinat/tableau.py.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh trac_12224-language-vd.patch
  1. Few broken doctests. Here are some testing errors I get on the my machine as well as on sage.math. Note that I tested only sage/combinat folder on my machine. This shows that some doctest are machine dependant (32bit vs 64 bits, ordering of string and int which depends on the machine : 'a'<9 vs 'a'>9 for cmp). Also for one of the doctest, 352 can be replaced by ... to avoid future problem with lines added before. More precisely,

The output of sage -t sage-5.6.rc0/devel/sage-language/sage/combinat/* run on my machine (32bit) which was first pasted here is now available here : http://sage.math.washington.edu/home/slabbe/trac_12224/bullet_4.txt.

The output of sage -t sage-5.6.rc1/devel/sage-12224/sage/* run on sage.math is here : http://sage.math.washington.edu/home/slabbe/sage-5.6.rc1/testing_12224.txt.

  1. Testing the sage-main files. I am interested in knowing whether my own code will continue to work after this ticket get merged. Eventually, I will test my own code during this review. But for now I did only one test : I check whether the doctests defined in the sage-main branch sage-5.6.rc0 still pass or not. I get 618 failures only for finite_word.py file. Some of them are __repr__ modifications that I can accept. But there are a lots of methods that do not exist anymore (maybe it is easy to fix?).

The output of sage -t sage-5.6.rc0/devel/sage-main/sage/combinat/* run on my machine which was first pasted here is now available here: http://sage.math.washington.edu/home/slabbe/trac_12224/bullet_5.txt.

The output of sage -t sage-5.6.rc1/devel/sage-main/sage/* run on sage.math is here : http://sage.math.washington.edu/home/slabbe/sage-5.6.rc1/testing_12224_on_sage-main.txt.

Last edited 10 years ago by slabbe (previous) (diff)

comment:11 Changed 10 years ago by slabbe

I removed this comment after reorganisation.

Last edited 10 years ago by slabbe (previous) (diff)

comment:12 Changed 10 years ago by slabbe

5 (bis). Continuing point above (testing doctests in the clean sage-main branch of sage-5.6.rc0 to see how the old behavior is changed). For now, I tested only sage/combinat folder. All tests pass on many of them. I get errors on 28 files and time out on 3 files. See below for the list of files.

Below, I put some samples of failing doctests that will break my code and code of other users. These must be fixed. I can't see an argument for removing a working method from Sage...

~/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat $ sage -t *

[...]

----------------------------------------------------------------------
The following tests failed:


	sage -t  "devel/sage-main/sage/combinat/debruijn_sequence.pyx"
	sage -t  "devel/sage-main/sage/combinat/e_one_star.py"
	sage -t  "devel/sage-main/sage/combinat/free_module.py"
	sage -t  "devel/sage-main/sage/combinat/iet/constructors.py"
	sage -t  "devel/sage-main/sage/combinat/iet/labelled.py"
	sage -t  "devel/sage-main/sage/combinat/iet/reduced.py"
	sage -t  "devel/sage-main/sage/combinat/iet/template.py"
	sage -t  "devel/sage-main/sage/combinat/lyndon_word.py"
	sage -t  "devel/sage-main/sage/combinat/ribbon.py"
	sage -t  "devel/sage-main/sage/combinat/ribbon_tableau.py"
	sage -t  "devel/sage-main/sage/combinat/sf/ns_macdonald.py"
	sage -t  "devel/sage-main/sage/combinat/skew_tableau.py"
	sage -t  "devel/sage-main/sage/combinat/tableau.py"
	sage -t  "devel/sage-main/sage/combinat/tableau_tuple.py"
	sage -t  "devel/sage-main/sage/combinat/words/abstract_word.py"
	sage -t  "devel/sage-main/sage/combinat/words/alphabet.py" # Time out
	sage -t  "devel/sage-main/sage/combinat/words/finite_word.py"
	sage -t  "devel/sage-main/sage/combinat/words/infinite_word.py"
	sage -t  "devel/sage-main/sage/combinat/words/morphism.py" # Time out
	sage -t  "devel/sage-main/sage/combinat/words/paths.py"
	sage -t  "devel/sage-main/sage/combinat/words/shuffle_product.py"
	sage -t  "devel/sage-main/sage/combinat/words/suffix_trees.py"
	sage -t  "devel/sage-main/sage/combinat/words/word.py"
	sage -t  "devel/sage-main/sage/combinat/words/word_datatypes.pyx"
	sage -t  "devel/sage-main/sage/combinat/words/word_generators.py" # Time out
	sage -t  "devel/sage-main/sage/combinat/words/word_infinite_datatypes.py"
	sage -t  "devel/sage-main/sage/combinat/words/word_options.py"
	sage -t  "devel/sage-main/sage/combinat/words/words.py"
Total time for all tests: 2640.3 seconds
sage -t  "devel/sage-main/sage/combinat/debruijn_sequence.pyx"
**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/debruijn_sequence.pyx", line 18:
    sage: print Word(seq).string_rep()
Exception raised:
    Traceback (most recent call last):
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_0[4]>", line 1, in <module>
        print Word(seq).string_rep()###line 18:
    sage: print Word(seq).string_rep()
      File "element.pyx", line 332, in sage.structure.element.Element.__getattr__ (sage/structure/element.c:3527)
      File "misc.pyx", line 204, in sage.structure.misc.getattr_from_other_class (sage/structure/misc.c:1488)
    AttributeError: 'sage.combinat.words.word_datatypes.FiniteWord_list' object has no attribute 'string_rep'
**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/debruijn_sequence.pyx", line 21:
    sage: for i in range(2**3):
         print (Word(map(lambda (j,b): b if j in shift(i) else '*',
                                          enumerate(seq))).string_rep())
Exception raised:
    Traceback (most recent call last):
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_0[6]>", line 3, in <module>
        enumerate(seq))).string_rep())
      File "element.pyx", line 332, in sage.structure.element.Element.__getattr__ (sage/structure/element.c:3527)
      File "misc.pyx", line 204, in sage.structure.misc.getattr_from_other_class (sage/structure/misc.c:1488)
    AttributeError: 'sage.combinat.words.word_datatypes.FiniteWord_list' object has no attribute 'string_rep'
**********************************************************************
1 items had failures:
   2 of   9 in __main__.example_0
***Test Failed*** 2 failures.

Why the comma is removed in the following representation of WordMorphism??

sage -t  "devel/sage-main/sage/combinat/e_one_star.py"      
**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/e_one_star.py", line 178:
    sage: E
Expected:
    E_1^*(1->12, 10->1,11, 11->1,12, 12->1, 2->13, 3->14, 4->15, 5->16, 6->17, 7->18, 8->19, 9->1,10)
Got:
    E_1^*(1->1.2 2->1.3 3->1.4 4->1.5 5->1.6 ...)
**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/e_one_star.py", line 1442:
    sage: E
Expected:
    E_1^*(1->12, 2->13, 3->1)
Got:
    E_1^*(1->12 2->13 3->1)
**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/e_one_star.py", line 1572:
    sage: E1Star(s) * E1Star(t)
Expected:
    E_1^*(1->1, 2->1132, 3->1311)
Got:
    E_1^*(1->1 2->1132 3->1311)
**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/e_one_star.py", line 1574:
    sage: E1Star(t * s)
Expected:
    E_1^*(1->1, 2->1132, 3->1311)
Got:
    E_1^*(1->1 2->1132 3->1311)
**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/e_one_star.py", line 1590:
    sage: E
Expected:
    E_1^*(1->12, 2->13, 3->1)
Got:
    E_1^*(1->12 2->13 3->1)
**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/e_one_star.py", line 1668:
    sage: E.sigma()
Expected:
    WordMorphism: 1->12, 2->13, 3->1
Got:
    1->12 2->13 3->1
**********************************************************************
5 items had failures:
   1 of  51 in __main__.example_0
   1 of   7 in __main__.example_37
   2 of   8 in __main__.example_40
   1 of   7 in __main__.example_41
   1 of   7 in __main__.example_45
***Test Failed*** 6 failures.
For whitespace errors, see the file /Users/slabbe/.sage//tmp/e_one_star_12815.py
	 [11.6 s]

So a.b.c is the new way of printing words?

sage -t  "devel/sage-main/sage/combinat/free_module.py"     
**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/free_module.py", line 785:
    sage: (1+q)*V(w)
Expected:
    (q+1)*B[word: abc]
Got:
    (q+1)*B[a.b.c]
**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/free_module.py", line 787:
    sage: ((1+q)/q)*V(w)
Expected:
    ((q+1)/q)*B[word: abc]
Got:
    ((q+1)/q)*B[a.b.c]
**********************************************************************
1 items had failures:
   2 of  27 in __main__.example_24
***Test Failed*** 2 failures.
For whitespace errors, see the file /Users/slabbe/.sage//tmp/free_module_12843.py
	 [5.3 s]

I don't agree with the new printing of WordMorphism?. We changed it and had a discussion recently in #13677. Why should we change it again? Anyway, this discussion is independant of this ticket. I suggest this is not changed by this ticket and is discussed elsewhere.

sage -t  "devel/sage-main/sage/combinat/iet/constructors.py"
**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/iet/constructors.py", line 729:
    sage: s
Expected:
    WordMorphism: a->acbbc, b->acbbcbbc, c->acbc
Got:
    a->acbbc b->acbbcbbc c->acbc
**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/iet/constructors.py", line 749:
    sage: w1
Expected:
    word: acbbcacbcacbbcbbcacb
Got:
    acbbcacbcacbbcbbcacb
**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/iet/constructors.py", line 752:
    sage: w2[:20]
Expected:
    word: acbbcacbcacbbcbbcacb
Got:
    acbbcacbcacbbcbbcacb
**********************************************************************
1 items had failures:
   3 of  33 in __main__.example_5
***Test Failed*** 3 failures.
For whitespace errors, see the file /Users/slabbe/.sage//tmp/constructors_12870.py
	 [4.8 s]

Why does LyndonWords() does not work anymore ?

sage -t  "devel/sage-main/sage/combinat/lyndon_word.py"     
**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/lyndon_word.py", line 59:
    sage: LyndonWords()
Exception raised:
    Traceback (most recent call last):
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_1[2]>", line 1, in <module>
        LyndonWords()###line 59:
    sage: LyndonWords()
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/lib/python/site-packages/sage/combinat/lyndon_word.py", line 109, in LyndonWords
        raise NotImplementedError
    NotImplementedError
**********************************************************************

[...]

**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/lyndon_word.py", line 117:
    sage: LyndonWord([1,2,2])
Exception raised:
    Traceback (most recent call last):
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_2[2]>", line 1, in <module>
        LyndonWord([Integer(1),Integer(2),Integer(2)])###line 117:
    sage: LyndonWord([1,2,2])
    NameError: name 'LyndonWord' is not defined
**********************************************************************

Methods disappeared :

sage -t  "devel/sage-main/sage/combinat/words/abstract_word.py"
**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/words/abstract_word.py", line 17:
    sage: p = f.longest_common_prefix(g, length='finite')
Exception raised:
    Traceback (most recent call last):
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_0[5]>", line 1, in <module>
        p = f.longest_common_prefix(g, length='finite')###line 17:
    sage: p = f.longest_common_prefix(g, length='finite')
      File "element.pyx", line 332, in sage.structure.element.Element.__getattr__ (sage/structure/element.c:3527)
      File "misc.pyx", line 200, in sage.structure.misc.getattr_from_other_class (sage/structure/misc.c:1406)
    AttributeError: 'RightInfiniteWord_iterable_with_category' object has no attribute 'longest_common_prefix'
**********************************************************************
[...]

**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/words/abstract_word.py", line 45:
    sage: Word(iter([1,2,3]), length="unknown").parent()
Exception raised:
    Traceback (most recent call last):
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_1[2]>", line 1, in <module>
        Word(iter([Integer(1),Integer(2),Integer(3)]), length="unknown").parent()###line 45:
    sage: Word(iter([1,2,3]), length="unknown").parent()
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/lib/python/site-packages/sage/combinat/words/word.py", line 262, in Word
        return parent(data, **options)
      File "parent.pyx", line 809, in sage.structure.parent.Parent.__call__ (sage/structure/parent.c:7408)
      File "coerce_maps.pyx", line 100, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_with_args (sage/structure/coerce_maps.c:4004)
      File "coerce_maps.pyx", line 90, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_with_args (sage/structure/coerce_maps.c:3816)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/lib/python/site-packages/sage/combinat/words/words.py", line 1700, in _element_constructor_
        return self.finite_words()(data, **options)
      File "parent.pyx", line 809, in sage.structure.parent.Parent.__call__ (sage/structure/parent.c:7408)
      File "coerce_maps.pyx", line 100, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_with_args (sage/structure/coerce_maps.c:4004)
      File "coerce_maps.pyx", line 90, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_with_args (sage/structure/coerce_maps.c:3816)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/lib/python/site-packages/sage/combinat/languages/base_class.py", line 364, in _element_constructor_
        w = ec(data,self,**kkwds)
      File "word_datatypes.pyx", line 31, in sage.combinat.words.word_datatypes.FiniteWord_list.__init__ (sage/combinat/words/word_datatypes.c:2030)
    TypeError: __init__() got an unexpected keyword argument 'cache'
**********************************************************************

[...]

**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/words/abstract_word.py", line 663:
    sage: w = Word(iter("abbacabba"))
Exception raised:
    Traceback (most recent call last):
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_16[6]>", line 1, in <module>
        w = Word(iter("abbacabba"))###line 663:
    sage: w = Word(iter("abbacabba"))
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/lib/python/site-packages/sage/combinat/words/word.py", line 262, in Word
        return parent(data, **options)
      File "parent.pyx", line 807, in sage.structure.parent.Parent.__call__ (sage/structure/parent.c:7388)
      File "coerce_maps.pyx", line 82, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_ (sage/structure/coerce_maps.c:3583)
      File "coerce_maps.pyx", line 77, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_ (sage/structure/coerce_maps.c:3485)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/lib/python/site-packages/sage/combinat/words/words.py", line 1705, in _element_constructor_
        return self.infinite_words()(data, **options)
      File "parent.pyx", line 809, in sage.structure.parent.Parent.__call__ (sage/structure/parent.c:7408)
      File "coerce_maps.pyx", line 100, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_with_args (sage/structure/coerce_maps.c:4004)
      File "coerce_maps.pyx", line 90, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_with_args (sage/structure/coerce_maps.c:3816)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/lib/python/site-packages/sage/categories/shifts.py", line 376, in _element_constructor_
        self.check_element(w)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/lib/python/site-packages/sage/dynamics/symbolic/full_shift.py", line 217, in check_element
        if elt[i] not in A:
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/lib/python/site-packages/sage/combinat/words/lazy_word.py", line 791, in __getitem__
        return self._get_letter(key)
      File "lazy_list.pyx", line 615, in sage.misc.lazy_list.lazy_list.__call__ (sage/misc/lazy_list.c:3849)
    IndexError: lazy list index out of range
**********************************************************************

[...]

**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/words/abstract_word.py", line 730:
    sage: w.lex_less(u)
Exception raised:
    Traceback (most recent call last):
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_18[5]>", line 1, in <module>
        w.lex_less(u)###line 730:
    sage: w.lex_less(u)
      File "element.pyx", line 332, in sage.structure.element.Element.__getattr__ (sage/structure/element.c:3527)
      File "misc.pyx", line 204, in sage.structure.misc.getattr_from_other_class (sage/structure/misc.c:1488)
    AttributeError: 'sage.combinat.words.word_datatypes.FiniteWord_list' object has no attribute 'lex_less'
**********************************************************************

[...]

**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/words/abstract_word.py", line 794:
    sage: w.apply_morphism(d)
Exception raised:
    Traceback (most recent call last):
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_20[4]>", line 1, in <module>
        w.apply_morphism(d)###line 794:
    sage: w.apply_morphism(d)
      File "element.pyx", line 332, in sage.structure.element.Element.__getattr__ (sage/structure/element.c:3527)
      File "misc.pyx", line 204, in sage.structure.misc.getattr_from_other_class (sage/structure/misc.c:1488)
    AttributeError: 'sage.combinat.words.word_datatypes.FiniteWord_str' object has no attribute 'apply_morphism'
**********************************************************************
[...]

**********************************************************************
34 items had failures:
   3 of   9 in __main__.example_0
   4 of   7 in __main__.example_1
   5 of   9 in __main__.example_11
  15 of  30 in __main__.example_12
   7 of  10 in __main__.example_13
   7 of  10 in __main__.example_14
   3 of   9 in __main__.example_15
   8 of  16 in __main__.example_16
   6 of  10 in __main__.example_17
   6 of  15 in __main__.example_18
   6 of  15 in __main__.example_19
   3 of   6 in __main__.example_2
   5 of  13 in __main__.example_20
   6 of  11 in __main__.example_21
   5 of  10 in __main__.example_22
  10 of  18 in __main__.example_23
  10 of  18 in __main__.example_24
  16 of  28 in __main__.example_25
   4 of   9 in __main__.example_26
   3 of   8 in __main__.example_27
   2 of   7 in __main__.example_28
  11 of  16 in __main__.example_3
   9 of  16 in __main__.example_30
   2 of  18 in __main__.example_31
   9 of  19 in __main__.example_32
  10 of  17 in __main__.example_33
   4 of   9 in __main__.example_34
   8 of  15 in __main__.example_35
   7 of  12 in __main__.example_36
   3 of   6 in __main__.example_4
   5 of  12 in __main__.example_5
   4 of   9 in __main__.example_6
   3 of  10 in __main__.example_7
   7 of  13 in __main__.example_8
***Test Failed*** 216 failures.
For whitespace errors, see the file /Users/slabbe/.sage//tmp/abstract_word_14102.py
**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/words/shuffle_product.py", line 255:
    sage: S = ShuffleProduct_overlapping(w,u)
Exception raised:
    Traceback (most recent call last):
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_12[4]>", line 1, in <module>
        S = ShuffleProduct_overlapping(w,u)###line 255:
    sage: S = ShuffleProduct_overlapping(w,u)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/lib/python/site-packages/sage/combinat/words/shuffle_product.py", line 577, in __init__
        raise TypeError("w1 and w2 should be words over integers")
    TypeError: w1 and w2 should be words over integers
**********************************************************************
**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/words/word.py", line 362:
    sage: w.is_symmetric()
Exception raised:
    Traceback (most recent call last):
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_8[5]>", line 1, in <module>
        w.is_symmetric()###line 362:
    sage: w.is_symmetric()
      File "element.pyx", line 332, in sage.structure.element.Element.__getattr__ (sage/structure/element.c:3527)
      File "misc.pyx", line 200, in sage.structure.misc.getattr_from_other_class (sage/structure/misc.c:1406)
    AttributeError: 'FiniteWord_callable_with_category' object has no attribute 'is_symmetric'
**********************************************************************

[...]
**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/words/word.py", line 399:
    sage: prefix.minimal_period()
Exception raised:
    Traceback (most recent call last):
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_9[7]>", line 1, in <module>
        prefix.minimal_period()###line 399:
    sage: prefix.minimal_period()
      File "element.pyx", line 332, in sage.structure.element.Element.__getattr__ (sage/structure/element.c:3527)
      File "misc.pyx", line 204, in sage.structure.misc.getattr_from_other_class (sage/structure/misc.c:1488)
    AttributeError: 'sage.combinat.words.word_datatypes.FiniteWord_list' object has no attribute 'minimal_period'
**********************************************************************

**********************************************************************
File "/Users/slabbe/Applications/sage-5.6.rc0/devel/sage-main/sage/combinat/words/words.py", line 1217:
    sage: for m in W.iter_morphisms([2, 1]): m
Exception raised:
    Traceback (most recent call last):
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/Users/slabbe/Applications/sage-5.6.rc0/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_32[12]>", line 1, in <module>
        for m in W.iter_morphisms([Integer(2), Integer(1)]): m###line 1217:
    sage: for m in W.iter_morphisms([2, 1]): m
      File "parent.pyx", line 627, in sage.structure.parent.Parent.__getattr__ (sage/structure/parent.c:6187)
      File "misc.pyx", line 200, in sage.structure.misc.getattr_from_other_class (sage/structure/misc.c:1406)
    AttributeError: 'FiniteAndInfiniteWords_with_category' object has no attribute 'iter_morphisms'
**********************************************************************

Version 2, edited 10 years ago by slabbe (previous) (next) (diff)

comment:13 Changed 10 years ago by slabbe

  1. Question. If I understand correctly, the actual ticket does not depend on the following patches :
trac_13801-fix_facade_initialisation-vd.patch
trac_13803-limits.patch
trac_10962-pickle_set_pythontype.patch

Am I right?

Last edited 10 years ago by slabbe (previous) (diff)

comment:14 Changed 10 years ago by slabbe

3 (bis). I tested on sage-5.6.rc1 with the following tickets, and I still get the reject with the tableau file :

~/sage-5.6.rc1/devel/sage-12224$ hg qapplied
trac_8920-alphabet.patch
trac_12466-ss.patch
trac_12230-growing_letters-ss.patch
trac_12230-growing_letters-review-vd.patch
trac_13956-shift_argument.patch
trac_13957-catch_value_error.patch

~/sage-5.6.rc1/devel/sage-12224$ hg qpush
applying trac_12224-language.patch
patching file sage/combinat/tableau.py
Hunk #2 FAILED at 434
Hunk #4 FAILED at 584
Hunk #5 FAILED at 2070
3 out of 5 hunks FAILED -- saving rejects to file sage/combinat/tableau.py.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh trac_12224-language.patch

Moreover, with these tickets applied, sage does not start :

slabbe@sage:~/sage-5.6.rc1/devel/sage-12224$ ../../sage
----------------------------------------------------------------------
| Sage Version 5.6.rc1, Release Date: 2013-01-18                     |
| Type "notebook()" for the browser-based notebook interface.        |
| Type "help()" for help.                                            |
----------------------------------------------------------------------
**********************************************************************
*                                                                    *
* Warning: this is a prerelease version, and it may be unstable.     *
*                                                                    *
**********************************************************************
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)

[...]

/home/slabbe/sage-5.6.rc1/local/lib/python2.7/site-packages/sage/categories/category.pyc in <genexpr>((cat,))
    144     result = ()
    145     for category in categories:
--> 146         if any(cat.is_subcategory(category) for cat in result):
    147             continue
    148         result = tuple( cat for cat in result if not category.is_subcategory(cat) ) + (category,)

AttributeError: 'tuple' object has no attribute 'is_subcategory'
Error importing ipy_profile_sage - perhaps you should run %upgrade?
WARNING: Loading of ipy_profile_sage failed.

sage: 1+1
---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)

/home/slabbe/sage-5.6.rc1/devel/sage-12224/<ipython console> in <module>()

NameError: name 'Integer' is not defined

One need to add ticket #13801 as dependency.

Last edited 10 years ago by slabbe (previous) (diff)

comment:15 Changed 10 years ago by slabbe

  • Description modified (diff)

comment:16 Changed 10 years ago by slabbe

  • Description modified (diff)

comment:17 Changed 10 years ago by slabbe

4 (second bis). I tested the doctests of the whole sage library when applying the following 8 patches on sage-5.6.rc1.

trac_8920-alphabet.patch
trac_12466-ss.patch
trac_12230-growing_letters-ss.patch
trac_12230-growing_letters-review-vd.patch
trac_13801-fix_facade_initialisation-vd.patch
trac_13956-shift_argument.patch
trac_13957-catch_value_error.patch
trac_12224-language.patch

I get errors on the following files. The complete log is here.

The following tests failed:

	sage -t  devel/sage-12224/sage/structure/sage_object.pyx # 1 doctests failed
	sage -t  devel/sage-12224/sage/combinat/tableau_tuple.py # 2 doctests failed
	sage -t  devel/sage-12224/sage/categories/languages.py # 3 doctests failed
	sage -t  devel/sage-12224/sage/combinat/tableau.py # 3 doctests failed
	sage -t  devel/sage-12224/sage/combinat/languages/finite_word_language.py # 3 doctests failed
	sage -t  devel/sage-12224/sage/combinat/words/word_deprecation.py # 1 doctests failed
	sage -t  devel/sage-12224/sage/combinat/words/word.py # 1 doctests failed
	sage -t  devel/sage-12224/sage/combinat/words/maps.py # 22 doctests failed
----------------------------------------------------------------------
Timings have been updated.
Total time for all tests: 4281.6 seconds

Of course, all of these should be fixed. The first file indicates there are issues with pickling.

Last edited 10 years ago by slabbe (previous) (diff)

comment:18 Changed 10 years ago by slabbe

  • Dependencies changed from #8920, #12230, #12518, #13778, #13956, #13957 to #8920, #12230, #12518, #13778, #13956, #13957, #13801

comment:19 Changed 10 years ago by slabbe

  • Description modified (diff)

comment:20 Changed 10 years ago by slabbe

5 (second bis). Still to understand if my code will still work after this ticket, I tested the doctests of the sage-main of sage-5.6-rc1 when applying the following 8 patches on sage-5.6.rc1.

trac_8920-alphabet.patch
trac_12466-ss.patch
trac_12230-growing_letters-ss.patch
trac_12230-growing_letters-review-vd.patch
trac_13801-fix_facade_initialisation-vd.patch
trac_13956-shift_argument.patch
trac_13957-catch_value_error.patch
trac_12224-language.patch

It appears that a lot of doctests are failing. The complete log is here.

One observation is that the __repr__ and __str__ should not be changed in this ticket to help the reviewer. There is enough doctests failing already...

The following tests failed: 

	sage -t  devel/sage-main/sage/structure/sage_object.pyx # 1 doctests failed
	sage -t  devel/sage-main/sage/plot/plot.py # Time out
	sage -t  devel/sage-main/sage/combinat/words/finite_word.py # 618 doctests failed
	sage -t  devel/sage-main/sage/combinat/tableau_tuple.py # 2 doctests failed
	sage -t  devel/sage-main/sage/tests/cmdline.py # Time out
	sage -t  devel/sage-main/sage/combinat/words/paths.py # 114 doctests failed
	sage -t  devel/sage-main/sage/combinat/e_one_star.py # 6 doctests failed
	sage -t  devel/sage-main/sage/combinat/skew_tableau.py # 6 doctests failed
	sage -t  devel/sage-main/sage/combinat/tableau.py # 7 doctests failed
	sage -t  devel/sage-main/sage/categories/rings.py # 1 doctests failed
	sage -t  devel/sage-main/sage/categories/primer.py # 2 doctests failed
	sage -t  devel/sage-main/sage/combinat/words/suffix_trees.py # 45 doctests failed
	sage -t  devel/sage-main/sage/graphs/digraph_generators.py # 1 doctests failed
	sage -t  devel/sage-main/sage/combinat/ribbon.py # 6 doctests failed
	sage -t  devel/sage-main/sage/combinat/iet/reduced.py # 2 doctests failed
	sage -t  devel/sage-main/sage/combinat/free_module.py # 2 doctests failed
	sage -t  devel/sage-main/sage/combinat/words/word_generators.py # Time out
	sage -t  devel/sage-main/sage/combinat/sf/ns_macdonald.py # 1 doctests failed
	sage -t  devel/sage-main/sage/combinat/words/morphism.py # Time out
	sage -t  devel/sage-main/sage/categories/algebras.py # 6 doctests failed
	sage -t  devel/sage-main/sage/categories/sets_cat.py # 1 doctests failed
	sage -t  devel/sage-main/sage/sets/integer_range.py # 1 doctests failed
	sage -t  devel/sage-main/sage/sets/finite_set_maps.py # 7 doctests failed
	sage -t  devel/sage-main/sage/combinat/iet/template.py # 3 doctests failed
	sage -t  devel/sage-main/sage/categories/algebras_with_basis.py # 38 doctests failed
	sage -t  devel/sage-main/sage/categories/examples/algebras_with_basis.py # 5 doctests failed
	sage -t  devel/sage-main/sage/combinat/words/word_infinite_datatypes.py # 194 doctests failed
	sage -t  devel/sage-main/sage/combinat/words/word_options.py # 6 doctests failed
	sage -t  devel/sage-main/sage/sets/finite_set_map_cy.pyx # 2 doctests failed
	sage -t  devel/sage-main/sage/combinat/iet/constructors.py # 3 doctests failed
	sage -t  devel/sage-main/sage/combinat/debruijn_sequence.pyx # 2 doctests failed
	sage -t  devel/sage-main/sage/combinat/words/word_datatypes.pyx # 29 doctests failed
	sage -t  devel/sage-main/sage/sets/disjoint_set.pyx # 2 doctests failed
	sage -t  devel/sage-main/sage/combinat/lyndon_word.py # 23 doctests failed
	sage -t  devel/sage-main/sage/combinat/words/infinite_word.py # 14 doctests failed
	sage -t  devel/sage-main/sage/combinat/iet/labelled.py # 20 doctests failed
	sage -t  devel/sage-main/sage/combinat/words/abstract_word.py # 220 doctests failed
	sage -t  devel/sage-main/sage/combinat/words/shuffle_product.py # 16 doctests failed
	sage -t  devel/sage-main/sage/combinat/ribbon_tableau.py # 1 doctests failed
	sage -t  devel/sage-main/sage/combinat/words/word.py # 97 doctests failed
	sage -t  devel/sage-main/sage/combinat/words/words.py # 207 doctests failed
	sage -t  devel/sage-main/sage/categories/modules_with_basis.py # 3 doctests failed
	sage -t  devel/sage-main/sage/combinat/words/alphabet.py # Time out
----------------------------------------------------------------------
Timings have been updated.
Total time for all tests: 2331.8 seconds

For what reason each of these tests are failing? If it is because of a string repr that changed, this should be reverted and postpone in another ticket. If it is some hidden method starting with an underscore that was change : ok. If some result of type(something) changed because the class name has changed : ok. But if it is a normal method, it should still work after the ticket.

Last edited 10 years ago by slabbe (previous) (diff)

comment:21 Changed 10 years ago by slabbe

  • Status changed from new to needs_review

comment:22 Changed 10 years ago by slabbe

  • Reviewers set to Sébastien Labbé
  • Status changed from needs_review to needs_work
  • Work issues set to pickling, doctests errors, revert changes on repr, ...

comment:23 in reply to: ↑ 10 Changed 10 years ago by slabbe

I just reorganized my comments which were all mixed up. See Comment 10 for an up to date summary.

comment:24 Changed 9 years ago by tjolivet

  • Cc tjolivet added

comment:25 Changed 9 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:26 Changed 9 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:27 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:28 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:29 Changed 6 years ago by jepperlein

  • Cc jepperlein added

comment:30 Changed 4 years ago by slabbe

Vincent, should we close this ticket as "won't fix" since some of the issue was dealt partly in several disjoint other tickets (done or still to be done)?

comment:31 Changed 4 years ago by vdelecroix

Word/FiniteWord does not inherits from Element/Parent. Why would you want to close this ticket? Where has this problem been dealt with?

comment:32 Changed 4 years ago by slabbe

I would suggest to start over in a new ticket, or alternatively, can you please update the description of this ticket to the goal you see it has?

comment:33 Changed 9 months ago by vdelecroix

  • Description modified (diff)
  • Milestone changed from sage-6.4 to sage-9.1.1

comment:34 Changed 9 months ago by vdelecroix

  • Description modified (diff)

comment:35 Changed 3 months ago by chapoton

  • Milestone changed from sage-9.1.1 to sage-wishlist
Note: See TracTickets for help on using tickets.