Changes between Version 3 and Version 4 of Ticket #12224, comment 10


Ignore:
Timestamp:
01/29/13 21:20:29 (10 years ago)
Author:
slabbe
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12224, comment 10

    v3 v4  
    11I started the review. Here is a first bunch of comments.
    22
    3 1. '''Goal of the ticket.''' The goal of this patch reimplements the code structure of {{{sage/combinat/words}}} using categories. It also adds classes for languages which is a good thing that I would need for my own research. It touches other files outside of this folder. It also depends on some particular tickets fixing bugs in Cython (#13957) and other patches that apply on similar files which do not commute with this huge patch. Moreover since it is a huge patch touching many files, it prevents any user/developper to change any code in {{{sage/combinat/words}}} without creating conflicts. So I hope this will not take forever to get reviewed because meanwhile it prevents the evolution of the actual code.
     31. '''Goal of the ticket: Categories in {{{sage/combinat/words}}} library.''' The goal of this patch reimplements the code structure of {{{sage/combinat/words}}} using categories. It also adds classes for languages which is a good thing that I would need for my own research. It touches other files outside of this folder. It also depends on some particular tickets fixing bugs in Cython (#13957) and other patches that apply on similar files which do not commute with this huge patch. Moreover since it is a huge patch touching many files, it prevents any user/developper to change any code in {{{sage/combinat/words}}} without creating conflicts. So I hope this will not take forever to get reviewed because meanwhile it prevents the evolution of the actual code.
    44
    552. '''Content of the patch.''' It is a huge patch (1.3MG). It modifies 40 files, add 27 files and removes 6 files (see detailed list below). It is hard for any reviewer to make sure he doesn't miss a problem possibly added by the patch. Is there a way to cut the patch in different chunks (tickets) which could make it more easy to get it into Sage because easier for reviewers?