Opened 10 years ago
Closed 10 years ago
#12176 closed defect (fixed)
Compute Minkowski bound for relative number fields
Reported by: | mkosters | Owned by: | davidloeffler |
---|---|---|---|
Priority: | minor | Milestone: | sage-4.8 |
Component: | number fields | Keywords: | |
Cc: | Merged in: | sage-4.8.alpha5 | |
Authors: | Michiel Kosters | Reviewers: | Monique van Beek |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
sage: K.<y,z>=NumberField([x^2-2,x^2-3]) sage: K.minkowski_bound() ... NotImplementedError: For a relative number field you must use relative_degree or absolute_degree as appropriate
Apply 12176_3.patch
Attachments (4)
Change History (11)
Changed 10 years ago by
comment:1 Changed 10 years ago by
- Status changed from new to needs_review
comment:2 Changed 10 years ago by
- Status changed from needs_review to needs_work
Changed 10 years ago by
Changed 10 years ago by
comment:3 Changed 10 years ago by
- Description modified (diff)
- Status changed from needs_work to needs_review
Fixed the whitespace and
comment:4 Changed 10 years ago by
- Description modified (diff)
Changed 10 years ago by
comment:5 Changed 10 years ago by
- Priority changed from major to minor
- Reviewers set to Monique van Beek
- Status changed from needs_review to positive_review
Patch also works in following case:
sage: K.<a,b,c>=NumberField([x^2-3,x^2-7,x^3-2]) sage: K.minkowski_bound() 2641100/pi^4^^
comment:6 Changed 10 years ago by
- Summary changed from Compute Minkowsky bound for relative number fields to Compute Minkowski bound for relative number fields
comment:7 Changed 10 years ago by
- Merged in set to sage-4.8.alpha5
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
There are some style issues with respect to whitespace (explained to the author in person). Furthermore, the documentation of absolute_discriminant speaks of a "relative discriminant". Speaking of this, you could also define the relative_discriminant of QQ.