Opened 11 years ago

Closed 11 years ago

# Compute Minkowski bound for relative number fields

Reported by: Owned by: mkosters davidloeffler minor sage-4.8 number fields sage-4.8.alpha5 Michiel Kosters Monique van Beek N/A

```sage: K.<y,z>=NumberField([x^2-2,x^2-3])
sage: K.minkowski_bound()
...
NotImplementedError: For a relative number field you must use relative_degree or absolute_degree as appropriate
```

Apply 12176_3.patch

### comment:1 Changed 11 years ago by mkosters

Status: new → needs_review

### comment:2 Changed 11 years ago by johanbosman

Status: needs_review → needs_work

There are some style issues with respect to whitespace (explained to the author in person). Furthermore, the documentation of absolute_discriminant speaks of a "relative discriminant". Speaking of this, you could also define the relative_discriminant of QQ.

### comment:3 Changed 11 years ago by mkosters

Description: modified (diff) needs_work → needs_review

Fixed the whitespace and

### comment:4 Changed 11 years ago by mkosters

Description: modified (diff)

### comment:5 Changed 11 years ago by MvanBeek

Authors: → Michiel Kosters major → minor → Monique van Beek needs_review → positive_review

Patch also works in following case:

```sage: K.<a,b,c>=NumberField([x^2-3,x^2-7,x^3-2])
sage: K.minkowski_bound()
2641100/pi^4^^
```

### comment:6 Changed 11 years ago by jdemeyer

Summary: Compute Minkowsky bound for relative number fields → Compute Minkowski bound for relative number fields

### comment:7 Changed 11 years ago by jdemeyer

Merged in: → sage-4.8.alpha5 → fixed positive_review → closed
Note: See TracTickets for help on using tickets.