Changes between Initial Version and Version 1 of Ticket #12142, comment 16


Ignore:
Timestamp:
Jul 17, 2013, 2:45:55 PM (10 years ago)
Author:
pbruin
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12142, comment 16

    initial v1  
    11The next patch removes the Cython constructor `__cinit__()`, which is unnecessary since it just sets an attribute to NULL which is already guaranteed to be NULL.  Actually, it just comments it out with an explanation for future reference.  This should fix the remaining doctest failure and may give another slight speed improvement.
    2 
    3 (I'm leaving this as "positive_review" since I can't set it back to "needs_review" immediately.  The change is not entirely trivial, though.)