Opened 10 years ago

Closed 10 years ago

#12138 closed defect (fixed)

Fix parallel building zlib

Reported by: jdemeyer Owned by: tbd
Priority: critical Milestone: sage-4.8
Component: packages: standard Keywords:
Cc: jhpalmieri Merged in: sage-4.8.alpha4
Authors: Jeroen Demeyer Reviewers: John Palmieri
Report Upstream: Reported upstream. Little or no feedback. Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Attachments (1)

zlib-1.2.5-p0.diff (1.7 KB) - added by jdemeyer 10 years ago.
Diff for the zlib spkg, for review only

Download all attachments as: .zip

Change History (8)

comment:1 Changed 10 years ago by jdemeyer

  • Report Upstream changed from N/A to Not yet reported upstream; Will do shortly.

comment:2 Changed 10 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Description modified (diff)

comment:3 Changed 10 years ago by jdemeyer

  • Status changed from new to needs_review

John, could you please test both the old and new zlib spkgs using

MAKEFLAGS="j8" ./sage -f zlib...

(or some other value of j)

On Linux, I do not manage to reproduce the issue.

comment:4 Changed 10 years ago by jdemeyer

  • Report Upstream changed from Not yet reported upstream; Will do shortly. to Reported upstream. Little or no feedback.

Managed to reproduce anyway with the old zlib on sage.math, not with the new one here. So looks good, but needs formal review.

Changed 10 years ago by jdemeyer

Diff for the zlib spkg, for review only

comment:5 Changed 10 years ago by jdemeyer

  • Description modified (diff)

comment:6 Changed 10 years ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

Looks good to me and builds consistently on sage.math and on OS X, under circumstances where the old spkg failed. (For example, on OS X, I got the old spkg to fail on 7 out of 10 builds, while this one built 20 times in row with no failures, and similarly on sage.math, using MAKEFLAGS='j -l2' ./sage -f ....)

comment:7 Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.8.alpha4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.