Opened 10 years ago

Last modified 21 months ago

#12133 needs_work enhancement

New spkg for extended tables of prime factors

Reported by: roed Owned by: tbd
Priority: major Milestone: sage-6.4
Component: factorization Keywords:
Cc: zimmerma, jpflori Merged in:
Authors: David Roe Reviewers: R. Andrew Ohana
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #12125 Stopgaps:

Status badges

Description

Richard Brent has tables of prime factors of numbers of the form bk + 1 and bk - 1 extending beyond the scope of the Cunningham tables. They can be found at his website http://maths.anu.edu.au/~brent/factors.html. This spkg adds them to Sage, and the corresponding patch uses the data in integer factorization if it's available.

Attachments (2)

12133.patch (29.0 KB) - added by roed 10 years ago.
12133_sql.patch (39.7 KB) - added by roed 10 years ago.
Changes the brent spkg to use an SQL database

Download all attachments as: .zip

Change History (15)

Changed 10 years ago by roed

comment:1 follow-up: Changed 10 years ago by roed

  • Status changed from new to needs_review

comment:2 Changed 10 years ago by roed

You should apply both patches, and use the new spkg: Brent_Tables-1.1

Changed 10 years ago by roed

Changes the brent spkg to use an SQL database

comment:3 Changed 10 years ago by zimmerma

  • Cc zimmerma added

comment:4 Changed 10 years ago by ohanar

  • Reviewers set to R. Andrew Ohana
  • Status changed from needs_review to needs_work

Few comments:

  • PrimeTable is maybe a bit too generic, maybe PrimeFactorTable would be better?
  • suggest sage -i brent_tables to install the package, it means less updating of the sage library
  • optional tag should match the name of the spkg

Do these tables include the Cunningham tables? If so, wouldn't it make sense to make a function that returns the BrentDatabase if these tables are installed or the CunninghamDatabase if they are not (like how the CremonaDatabase is done). That way the only part of the sage library that would care about which database is being used is this database code (also, you wouldn't have to do your funky BrentDatabase initializer).

comment:5 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:6 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:7 Changed 8 years ago by jpflori

  • Cc jpflori added

comment:8 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:9 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:10 in reply to: ↑ 1 Changed 4 years ago by rws

Replying to roed:

This patch accompanies a new spkg: http://sage.math.washington.edu/home/roed/brent_tables-1.0.spkg

This gives a 101 error.

comment:11 Changed 4 years ago by roed

Thanks for looking into this. I can probably track down this spkg, but I'm going to be unavailable for the next few weeks.

comment:12 Changed 21 months ago by dimpase

ping? this ticket comes up in regard of cunningham_tables spkg, which is said to be a subset of this one.

comment:13 Changed 21 months ago by roed

Taking a look now....

Note: See TracTickets for help on using tickets.