Opened 9 years ago
Closed 9 years ago
#12127 closed defect (duplicate)
fix comparison R == Z
Reported by: | fschulze | Owned by: | AlexGhitza |
---|---|---|---|
Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |
Component: | algebraic geometry | Keywords: | sd40.5 |
Cc: | saraedum, vbraun | Merged in: | |
Authors: | Reviewers: | Andrey Novoseltsev, Frithjof Schulze | |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Two methods in schemes/generic/homset.py contain a comparison 'R == Z' instead of 'R == ZZ'.
Fixed by #11526.
Change History (10)
comment:1 Changed 9 years ago by
- Cc vbraun added
comment:2 Changed 9 years ago by
See also #11526.
comment:3 Changed 9 years ago by
- Milestone changed from sage-4.8 to sage-duplicate/invalid/wontfix
I changed the #11526 patch to also fix the typo in the projective case.
comment:4 Changed 9 years ago by
- Keywords sd40.5 added
- Reviewers set to Andrey Novoseltsev
- Status changed from new to needs_review
comment:5 Changed 9 years ago by
- Status changed from needs_review to positive_review
comment:6 follow-up: ↓ 7 Changed 9 years ago by
comment:7 in reply to: ↑ 6 Changed 9 years ago by
Replying to saraedum:
Oops. Should have read what was written in the ticket. Setting an author here doesn't make much sense.
comment:8 Changed 9 years ago by
- Status changed from positive_review to needs_work
This needs to be rebased to sage-5.1.beta0:
patching file sage/schemes/generic/homset.py Hunk #1 FAILED at 159 Hunk #2 FAILED at 218 2 out of 2 hunks FAILED -- saving rejects to file sage/schemes/generic/homset.py.rej
comment:9 Changed 9 years ago by
- Status changed from needs_work to positive_review
This ticket just has to be closed without merging anything!
comment:10 Changed 9 years ago by
- Description modified (diff)
- Resolution set to duplicate
- Reviewers changed from Andrey Novoseltsev to Andrey Novoseltsev, Frithjof Schulze
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Apparently this was introduced in [changeset:15345:08d4a1aad8b5].
About the doctests, could you provide some example which triggers the bug? We could probably use that for the doctest.