Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#12098 closed defect (fixed)

Readline should depend on termcap

Reported by: jdemeyer Owned by: GeorgSWeber
Priority: major Milestone: sage-4.8
Component: build Keywords:
Cc: Merged in: sage-4.8.alpha3
Authors: Jeroen Demeyer Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

Apply 12098_deps.patch to the SAGE_ROOT repository.

Attachments (1)

12098_deps.patch (3.3 KB) - added by jdemeyer 11 years ago.

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by jdemeyer

comment:1 Changed 11 years ago by jdemeyer

  • Status changed from new to needs_review

comment:2 Changed 11 years ago by jdemeyer

  • Description modified (diff)

comment:3 Changed 11 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

Nice.

comment:4 Changed 11 years ago by jdemeyer

  • Merged in set to sage-4.8.alpha3
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:5 follow-up: Changed 11 years ago by leif

Nice ticket description.

Note that Sage's readline spkg intentionally doesn't use the termcap shipped with Sage (which only builds a static library), so this ticket is in principle invalid as it suggests (or manifests) false assumptions.

comment:6 in reply to: ↑ 5 Changed 11 years ago by jdemeyer

Replying to leif:

Note that Sage's readline spkg intentionally doesn't use the termcap shipped with Sage (which only builds a static library), so this ticket is in principle invalid as it suggests (or manifests) false assumptions.

Well, that's far from clear when reading spkg/standard/deps. I don't think it's a problem though to have readline depend on termcap, in case we ever change our mind on readline/termcap.

Note: See TracTickets for help on using tickets.