Opened 10 years ago
Closed 10 years ago
#12096 closed defect (fixed)
Disable parallel "make install" in Python spkg
Reported by: | jdemeyer | Owned by: | tbd |
---|---|---|---|
Priority: | critical | Milestone: | sage-4.8 |
Component: | packages: standard | Keywords: | python spkg |
Cc: | Merged in: | sage-4.8.alpha4 | |
Authors: | Jeroen Demeyer | Reviewers: | François Bissey |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
The python spkg should not use parallel "make install". This is claimed to be fixed in the spkg, but it actually isn't done properly. There are some comments in spkg-install
about how to fix it.
Also, the python library should be installed with writable permission 0755, instead of 0555.
Apply http://boxen.math.washington.edu/home/jdemeyer/spkg/python-2.6.4.p12.spkg
Attachments (1)
Change History (15)
comment:1 Changed 10 years ago by
- Keywords python spkg added
- Summary changed from FIx parallel "make install" in Python to Disable parallel "make install" in Python spkg
comment:2 Changed 10 years ago by
- Description modified (diff)
comment:3 Changed 10 years ago by
- Priority changed from blocker to critical
comment:4 Changed 10 years ago by
- Type changed from PLEASE CHANGE to defect
comment:5 Changed 10 years ago by
- Description modified (diff)
comment:6 Changed 10 years ago by
- Status changed from new to needs_review
comment:7 Changed 10 years ago by
- Description modified (diff)
comment:8 Changed 10 years ago by
comment:9 follow-up: ↓ 10 Changed 10 years ago by
Darn I'll have to redo my python-2.7.2 spkg against this one. What is the purpose of the braces around the dpkg stuff?
comment:10 in reply to: ↑ 9 Changed 10 years ago by
Replying to fbissey:
Darn I'll have to redo my python-2.7.2 spkg against this one.
Yeah, sorry for that...
What is the purpose of the braces around the dpkg stuff?
To make the redirection work properly. The following are equivalent:
A >/dev/null && B >/dev/null
{ A && B; } >/dev/null
But are not equivalent to
A && B >/dev/null
comment:11 follow-up: ↓ 12 Changed 10 years ago by
- Reviewers set to François Bissey
I am looking at the spkg right now. It compiles fine and the patch look good. I have only one minor request about SPKG.txt before setting this to positive review. From the current SPKG.txt:
=== Patches === * cPickle.c.patch, pickle.py.patch: These add support for pickling classes with a metaclass via copy_reg. These have been submitted upstream: http://bugs.python.org/issue7689 * locale.py: Work around import failures for locales * readline-spacebug.patch: Fix issue where a space is inserted after tab completing at the command line. This is merged upstream and can be removed as soon as a Python newer than 2.6.4 is used. * readline-Itanium-fix.patch: Fix Itanium specific readline extension problem. * sdist.py.patch: Make sure that sdist copies over the .hg directory. * socket.py.patch: Work around an SSL issue. * Makefile.pre.in.patch: Fixes http://bugs.python.org/issue1628484 This was merged upstream for Python 2.6.6 and 2.7. * socketmodule.c Makes sure some things are defined before trying to compile them. This was to work around a failure of _socket to build on OpenSolaris. see http://bugs.python.org/issue8852 and Sage trac #9041 and #9022 * setup.py.multiarch.patch: Library search dir is expanded on Debian and derivatives with multiarch (see #11243, #11447). This requires 'dpkg-architecture' to be installed on the affected systems. (Since the patch origins from Python 2.7, it can certainly be removed when we upgrade to that. But the patch then won't apply anymore anyway.)
The section about Makefile.pre.in should mention your bit about installing things 0755.
comment:12 in reply to: ↑ 11 Changed 10 years ago by
Replying to fbissey:
The section about Makefile.pre.in should mention your bit about installing things 0755.
Done. I know I haven't commited the changes, but will do that after positive_review.
comment:13 Changed 10 years ago by
- Status changed from needs_review to positive_review
Good enough for me. It's all go.
comment:14 Changed 10 years ago by
- Merged in set to sage-4.8.alpha4
- Resolution set to fixed
- Status changed from positive_review to closed
I'd like to add a comment that writable permission 0755, instead of 0555, is important for Cygwin port, as it would permit (semi)automatic rebasing of Sage dlls without the need to fiddle with permissions.