Opened 9 years ago
Closed 9 years ago
#12089 closed defect (fixed)
Singular does not build on Cygwin - static libs problem
Reported by: | dimpase | Owned by: | tbd |
---|---|---|---|
Priority: | major | Milestone: | sage-5.4 |
Component: | packages: standard | Keywords: | singular, cygwin, spkg |
Cc: | vbraun, kcrisman, AlexanderDreyer, jdemeyer | Merged in: | sage-5.4.beta0 |
Authors: | Dmitrii Pasechnik, Karl-Dieter Crisman, Jean-Pierre Flori | Reviewers: | Karl-Dieter Crisman, Dmitrii Pasechnik, Jean-Pierre Flori |
Report Upstream: | Fixed upstream, but not in a stable release. | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #13237 | Stopgaps: |
Description (last modified by )
Singular does not build on Cygwin because libkernel and libhtmlhelp are not found. Indeed an include path which is set to ../kernel on generic systems is set to /bin on Cygwin.
Use the spkg at http://perso.telecom-paristech.fr/~flori/sage/singular-3-1-5.p1.spkg which fixes this.
Attachments (2)
Change History (25)
comment:1 Changed 9 years ago by
- Description modified (diff)
comment:2 Changed 9 years ago by
- Cc vbraun added
comment:3 Changed 9 years ago by
- Cc kcrisman added
comment:4 Changed 9 years ago by
- Description modified (diff)
comment:5 follow-up: ↓ 6 Changed 9 years ago by
comment:6 in reply to: ↑ 5 Changed 9 years ago by
Replying to kcrisman:
The draft package is malformed somehow.
sage: After decompressing the directory singular-3-1-3-3.p1-cygwindraft does not exist This means that the corresponding .spkg needs to be downloaded again.I think you have to name the spkg the same as the folder which is compressed. I'll try renaming the folder and trying it again.
rather, just rename the spkg file to singular-3-1-3-3.p1.spkg
comment:7 Changed 9 years ago by
This works.
$ ./sage -singular SINGULAR / Development A Computer Algebra System for Polynomial Computations / version 3-1-3 0< by: W. Decker, G.-M. Greuel, G. Pfister, H. Schoenemann \ March 2011 FB Mathematik der Universitaet, D-67653 Kaiserslautern \ > 2+2 . ; 4
Make it a proper spkg and let's get it in.
comment:8 Changed 9 years ago by
- Description modified (diff)
- Reviewers set to Karl-Dieter Crisman, Dmitrii Pasechnik
- Status changed from new to needs_review
I've done exactly that same thing in making spkgs before! Spkg is updated at singular-3-1-3-3.p2.spkg. The new patch only is applied on Cygwin. Diff attached for reference in review.
Dima, I'll test this just now, but if it builds, then I think it would just require you to sign off on it.
Dima or Volker or someone, can you report this upstream?
comment:9 Changed 9 years ago by
- Status changed from needs_review to needs_work
I don't really agree with the solution developed here.
My guess is that the Makefile.in is just broken because a -L../kernel on generic system got transformed into -L/bin.
I'll post an updated spkg based on the updated Singular spkg by Jeroen at #13237 with that approach when my new build on Cygwin fails at Singular. I'll report upstream as well.
comment:10 Changed 9 years ago by
You can try the spkg available at: http://perso.telecom-paristech.fr/~flori/sage/singular-3-1-5.p1.spkg
As it is based on the spkg from #13237 which has uncommitted changes, I've not committed anything yet either. However I'll attached the diffs here.
comment:11 Changed 9 years ago by
- Dependencies set to #12327
- Description modified (diff)
- Keywords spkg added
- Reviewers changed from Karl-Dieter Crisman, Dmitrii Pasechnik to Karl-Dieter Crisman, Dmitrii Pasechnik, Jean-Pierre Flori
- Status changed from needs_work to needs_review
comment:12 Changed 9 years ago by
- Dependencies changed from #12327 to #13237
comment:13 Changed 9 years ago by
- Report Upstream changed from Not yet reported upstream; Will do shortly. to Reported upstream. No feedback yet.
comment:14 Changed 9 years ago by
- Cc AlexanderDreyer added
- Report Upstream changed from Reported upstream. No feedback yet. to Fixed upstream, but not in a stable release.
There will be a likewise patch upstream, see here: https://github.com/alexanderdreyer/SingularSources/commit/7902222c6e73d452b3d75576bd9bc0140f5e827a Despite the slight differences I can get a positive review for your patch. (Edit: Sorry, wrong link! Fixed now.)
comment:15 Changed 9 years ago by
- Cc jdemeyer added
Thanks, the updated link makes more sense :)
We could also close this ticket and directly integrate your patch into Jeroen spkg from #13237 (which already includes other patches from singular trac/your github(? don't know the relation between them)). Anyway, even if we don't, we'll have for Jeroen skpg to get positive review.
comment:16 follow-up: ↓ 17 Changed 9 years ago by
I guess adding one more patch to #13237 doesn't hurt...
comment:17 in reply to: ↑ 16 Changed 9 years ago by
comment:18 Changed 9 years ago by
(never mind, wrong ticket)
comment:19 Changed 9 years ago by
comment:20 Changed 9 years ago by
- Status changed from needs_review to positive_review
This is indeed fixed on Cygwin and still builds on Linux (Ubuntu 12.04 x86_64). So positive review.
comment:21 Changed 9 years ago by
- Milestone changed from sage-5.3 to sage-pending
comment:22 Changed 9 years ago by
- Milestone changed from sage-pending to sage-5.4
comment:23 Changed 9 years ago by
- Merged in set to sage-5.4.beta0
- Resolution set to fixed
- Status changed from positive_review to closed
The draft package is malformed somehow.
I think you have to name the spkg the same as the folder which is compressed. I'll try renaming the folder and trying it again.