Opened 10 years ago
Closed 10 years ago
#12082 closed defect (fixed)
spkg-install of extcode, sage_scripts should preserve timestamp
| Reported by: | jdemeyer | Owned by: | leif |
|---|---|---|---|
| Priority: | blocker | Milestone: | sage-4.8 |
| Component: | scripts | Keywords: | |
| Cc: | Merged in: | sage-4.8.alpha3 | |
| Authors: | Jeroen Demeyer | Reviewers: | John Palmieri |
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
Status badges
Description (last modified by )
In script, I also remove the symlinks "sage.bin", "sage_pari" and "sage_singular" since these are nowhere used. Also I remove the script "sage-cleantmp" which is nowhere used and hasn't been edited since 2006.
After applying this patch, the release manager should run fixdate.sh once in the sage_scripts and extcode repositories to reset the modification times of the hg-tracked files.
Attachments (3)
Change History (13)
comment:1 Changed 10 years ago by
- Priority changed from major to blocker
comment:2 Changed 10 years ago by
- Description modified (diff)
comment:3 Changed 10 years ago by
- Description modified (diff)
comment:4 Changed 10 years ago by
- Description modified (diff)
comment:5 Changed 10 years ago by
- Description modified (diff)
Changed 10 years ago by
comment:6 follow-up: ↓ 7 Changed 10 years ago by
Regarding the use of cp -pr, on OS X, the man page for cp (from "BSD General Commands Manual") says
COMPATIBILITY
Historic versions of the cp utility had a -r option. This implementation supports that
option; however, its use is strongly discouraged, as it does not correctly copy special
files, symbolic links, or fifo's.
It would be better to use cp -pR, I think. (This also seems consistent with what I can find on the internet about POSIX standard options for cp.)
comment:7 in reply to: ↑ 6 Changed 10 years ago by
Replying to jhpalmieri:
It would be better to use
cp -pR, I think. (This also seems consistent with what I can find on the internet about POSIX standard options for cp.)
Fine. GNU coreutils cp doesn't differentiate between -r and -R (they behave identically), so I was unaware of this.
Changed 10 years ago by
Changed 10 years ago by
comment:8 Changed 10 years ago by
- Status changed from new to needs_review
comment:9 Changed 10 years ago by
- Reviewers set to John Palmieri
- Status changed from needs_review to positive_review
Looks good to me. Unnecessary note to release manager: make sure to run fixdate.sh on a system which uses GNU's version of touch; for example, this won't work on OS X.
comment:10 Changed 10 years ago by
- Merged in set to sage-4.8.alpha3
- Resolution set to fixed
- Status changed from positive_review to closed
Thanks for the review.
Shell script to change modification time of Mercurial-tracked files to the time of last commit