Opened 9 years ago
Closed 9 years ago
#12076 closed defect (fixed)
sage-location doesn't deal with packages after initialize_pkgconfig_files has run
Reported by: | mariah | Owned by: | tbd |
---|---|---|---|
Priority: | major | Milestone: | sage-5.1 |
Component: | scripts | Keywords: | sd40.5 |
Cc: | Merged in: | sage-5.1.beta4 | |
Authors: | Mike Hansen | Reviewers: | Dan Drake, Karl-Dieter Crisman |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
sage-4.7.2 with optional package libogg-1.1.4.spkg installed. Now when I move the sage tree I get:
eno% ./sage ---------------------------------------------------------------------- | Sage Version 4.7.2, Release Date: 2011-10-29 | | Type notebook() for the GUI, and license() for information. | ---------------------------------------------------------------------- The Sage installation tree may have moved (from /home/mariah/sage/sage-4.7.2-x86_64-Linux-core2-fc to /home/mariah/sage/sage-4.7.2-x86_64-Linux-core2-fc-libogg-test). Changing various hardcoded paths... (Please wait at most a few minutes.) DO NOT INTERRUPT THIS. Error: sage_location: update_pkgconfig_files(): File "ogg.pc" doesn't contain a definition of SAGE_ROOT. Skipping it... Done resetting paths. sage:
Apply:
Both trac_12076.patch and trac_12076-2.patch.
Attachments (2)
Change History (15)
Changed 9 years ago by
comment:1 Changed 9 years ago by
- Keywords sd40.5 added
- Status changed from new to needs_review
comment:2 Changed 9 years ago by
- Status changed from needs_review to needs_info
comment:3 follow-up: ↓ 4 Changed 9 years ago by
After installing the patch, did you move the Sage directory and start it?
comment:4 in reply to: ↑ 3 Changed 9 years ago by
Replying to mhansen:
After installing the patch, did you move the Sage directory and start it?
I did. And the relocation appears to work properly. I'm mostly just curious about the difference in the .pc
file.
comment:5 Changed 9 years ago by
I can confirm this problem, and that this patch fixes it, and the patch seems right, just abstracting out something.
But Dan and I agree that
config = config.replace(SAGE_ROOT_absolute, "${SAGE_ROOT}")
seems to not be happening here for some reason. But maybe we are parsing it wrong.
comment:6 Changed 9 years ago by
The new patch, which applies on top of the previous one, should (really!) fix this issue.
Changed 9 years ago by
comment:7 Changed 9 years ago by
- Reviewers set to Dan Drake
- Status changed from needs_info to needs_review
Whew! These two patches now fix the problem. To be sure, I'd like one more person to look at this, and then we'll do a positive review.
comment:8 Changed 9 years ago by
- Description modified (diff)
comment:9 Changed 9 years ago by
- Status changed from needs_review to positive_review
Karl-Dieter Crisman tried this and it works as expected. Positive review.
comment:10 Changed 9 years ago by
- Reviewers changed from Dan Drake to Dan Drake, Karl-Dieter Crisman
comment:11 Changed 9 years ago by
- Summary changed from optional package libogg-1.1.4.spkg causes error upon SAGE_ROOT relocation to sage-location doesn't deal with packages after initialize_pkgconfig_files has run
comment:12 Changed 9 years ago by
- Component changed from optional packages to scripts
comment:13 Changed 9 years ago by
- Merged in set to sage-5.1.beta4
- Resolution set to fixed
- Status changed from positive_review to closed
The patch here appears to fix the problem, but I notice that the
ogg.pc
file looks a little different from all the others:Observe that only
ogg.pc
has the originalSAGE_ROOT
in itsprefix
; all other files haveprefix
in terms ofSAGE_ROOT
. Is that what we want? Is that okay?