Changes between Initial Version and Version 6 of Ticket #12068


Ignore:
Timestamp:
11/23/11 14:34:37 (10 years ago)
Author:
burcin
Comment:

Declaring py_pow as an int caused problems with attachment:trac_12068-numer_denom_ginac-fh.patch. py_object_from_numeric() returns a PyObject. Assigning the return value to an int worked because Cython was creating a temporary PyObject and trying to convert that to an int. This failed if the exponent was not an integer.

attachment:trac_12068-denominator.patch fixes this problem and handles expressions which contain only a power.

Florent can you review my patch?

Apply attachment:trac_12068-numer_denom_ginac-fh.patch, attachment:trac_12068-denominator.patch

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12068

    • Property Status changed from new to needs_review
    • Property Authors changed from to Florent Hivert, Burcin Erocal
    • Property Summary changed from Numerator for symbolic expression should'nt use maxima to Numerator for symbolic expression shouldn't use maxima
    • Property Owner changed from burcin to hivert
    • Property Reviewers changed from to Burcin Erocal
  • Ticket #12068 – Description

    initial v6  
    1010}}}
    1111Using Pynac should be much faster.
     12
     13Apply attachment:trac_12068-numer_denom_ginac-fh.patch, attachment:trac_12068-denominator.patch