Opened 11 years ago
Last modified 5 weeks ago
#12064 needs_work enhancement
Update residue fields to use dynamic classes
Reported by:  roed  Owned by:  davidloeffler 

Priority:  major  Milestone:  
Component:  number fields  Keywords:  residue fields, dynamic classes 
Cc:  Merged in:  
Authors:  David Roe  Reviewers:  Simon Spicer 
Report Upstream:  N/A  Work issues:  
Branch:  u/saraedum/old_12064 (Commits, GitHub, GitLab)  Commit:  3545bf42c0106f25e7acafd35d54a8235f3182ef 
Dependencies:  #12062  Stopgaps: 
Description
Changes sage.rings.residue_fields to use sage.structure.dynamic_class to make it easier to implement padic residue fields.
Attachments (2)
Change History (22)
comment:1 Changed 11 years ago by
Status:  new → needs_review 

comment:2 Changed 11 years ago by
Status:  needs_review → needs_work 

comment:3 Changed 11 years ago by
Reviewers:  → spice 

comment:5 Changed 11 years ago by
Status:  needs_review → needs_work 

Looks like there's new trouble when trying to apply 12064 on top of 12062. 12062 has already been applied and Sage built in the output below:
sage@sagebox:~/sage/devel/sage$ hg qpush applying 12064.patch patching file sage/rings/finite_rings/finite_field_base.pyx Hunk #1 succeeded at 90 with fuzz 2 (offset 2 lines). patching file sage/rings/residue_field.pyx Hunk #3 succeeded at 139 with fuzz 2 (offset 0 lines). Hunk #8 succeeded at 435 with fuzz 2 (offset 0 lines). now at: 12064.patch sage@sagebox:~/sage/devel/sage$ sage b  sage: Building and installing modified Sage library files. Installing c_lib scons: `install' is up to date. Updating Cython code.... Building modified file sage/rings/residue_field.pyx. Building modified file sage/rings/finite_rings/finite_field_base.pyx. Executing 2 commands (using 1 thread) python `which cython` oldstyleglobals disablefunctionredefinition embedpositions directive cdivision=True,autotestdict=False,fast_getattr=True I/Users/sage/sage4.8/devel/sagedev1 o sage/rings/residue_field.c sage/rings/residue_field.pyx Error compiling Cython file:  ... K = pring.fraction_field() intp = pring.base_ring().order() f = p.gen() deg = f.degree() q = intp**deg if k == 1 and intp.is_prime() and (impl is None or impl == 'modn'): ^  sage/rings/residue_field.pyx:313:17: local variable 'k' referenced before assignment python `which cython` oldstyleglobals disablefunctionredefinition embedpositions directive cdivision=True,autotestdict=False,fast_getattr=True I/Users/sage/sage4.8/devel/sagedev1 o sage/rings/finite_rings/finite_field_base.c sage/rings/finite_rings/finite_field_base.pyx Error running command, failed with status 256. sage: There was an error installing modified sage library code.
comment:6 Changed 11 years ago by
Reviewers:  spice → Simon Spicer 

comment:7 Changed 10 years ago by
Status:  needs_work → needs_review 

Fixed. Sorry for the long delay.
Changed 10 years ago by
Attachment:  12064.patch added 

Changed 10 years ago by
Attachment:  trac_12064_review.patch added 

comment:8 Changed 9 years ago by
Milestone:  sage5.11 → sage5.12 

comment:9 Changed 9 years ago by
Milestone:  sage6.1 → sage6.2 

comment:10 Changed 9 years ago by
Milestone:  sage6.2 → sage6.3 

comment:11 Changed 8 years ago by
Milestone:  sage6.3 → sage6.4 

comment:12 Changed 8 years ago by
Status:  needs_review → needs_work 

comment:13 Changed 6 years ago by
Branch:  → u/saraedum/old_12064 

comment:14 Changed 6 years ago by
Commit:  → 6ec180c6186219d2c86de4fd05ad476c1fe4445c 

Branch pushed to git repo; I updated commit sha1. New commits:
6ec180c  Merge branch 'develop' into t/12064/old_12064

comment:15 Changed 6 years ago by
Commit:  6ec180c6186219d2c86de4fd05ad476c1fe4445c → 7bb1bf360124703b999fddf934bd7e88193a6b97 

Branch pushed to git repo; I updated commit sha1. New commits:
7bb1bf3  Fix build errors

comment:16 Changed 6 years ago by
Commit:  7bb1bf360124703b999fddf934bd7e88193a6b97 → 55203628a7406f7d6ae6ec4dc0be5e8a971b0813 

Branch pushed to git repo; I updated commit sha1. New commits:
5520362  Normalize interface for finite field construction

comment:17 Changed 6 years ago by
Commit:  55203628a7406f7d6ae6ec4dc0be5e8a971b0813 → ba525c796eeab599ee6a70e4a1e20803ad7f210c 

Branch pushed to git repo; I updated commit sha1. New commits:
ba525c7  Removed flaky type() tests

comment:18 Changed 6 years ago by
comment:19 Changed 12 months ago by
Commit:  ba525c796eeab599ee6a70e4a1e20803ad7f210c → 3545bf42c0106f25e7acafd35d54a8235f3182ef 

Branch pushed to git repo; I updated commit sha1. New commits:
3545bf4  Merge remotetracking branch 'trac/develop' into HEAD

comment:20 Changed 5 weeks ago by
Milestone:  sage6.4 

Is there another dependency? Patch fails to apply cleanly on a fresh copy of 4.8 on top of 12062: