Opened 9 years ago

Closed 3 years ago

#12050 closed defect (wontfix)

matrix_integer_dense.LLL: parameters for algorithm NTL:LLL

Reported by: dkrenn Owned by: jason, was
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: linear algebra Keywords: parameters, LLL
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

We have the following lines in matrix_integer_dense.pyx starting at line 2678 (corrected already the wrong algorithn, see #12049): 

        # FP choice
        if algorithm == 'NTL:LLL':
            if fp == None:
                algorithm = 'NTL:LLL_FP'
            elif fp == 'fp':
                algorithm = 'NTL:LLL_FP'
            elif fp == 'qd':
                algorithm = 'NTL:LLL_QD'
            elif fp == 'xd':
                algorithm = 'NTL:LLL_XD'
            elif fp == 'rr':
                algorithm = 'NTL:LLL_RR'
        elif algorithm == 'fpLLL:heuristic':
        ...

Later it is checked the following 

       if algorithm == "NTL:LLL":

This means, to get algorithm 'NTL:LLL' one has to set algorithm='NTL:LLL' and fp neither None nor any of 'fp', 'qd', 'xd', 'rr'. This is not intuitive at all and should not be.

Would it be a suitable solution to keep 'NTL:LLL' if fp=None?

Change History (8)

comment:1 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:2 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:3 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:4 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:5 Changed 3 years ago by gh-black-stones

I believe this has been changed sometime between sage-6.4 and sage-8.2rc4 

3086         if algorithm == 'NTL:LLL':
3087             if fp is None:
3088                 algorithm = 'NTL:LLL'
3089             elif fp == 'fp':
3090                 algorithm = 'NTL:LLL_FP'
3091             elif fp == 'qd':
3092                 algorithm = 'NTL:LLL_QD'
3093             elif fp == 'xd':
3094                 algorithm = 'NTL:LLL_XD'
3095             elif fp == 'rr':
3096                 algorithm = 'NTL:LLL_RR'

comment:6 Changed 3 years ago by gh-black-stones

  • Status changed from new to needs_review

comment:7 Changed 3 years ago by chapoton

  • Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix
  • Status changed from needs_review to positive_review

ok

comment:8 Changed 3 years ago by vdelecroix

  • Resolution set to wontfix
  • Status changed from positive_review to closed

closing positively reviewed duplicates

Note: See TracTickets for help on using tickets.