Opened 11 years ago

Last modified 2 months ago

#12015 new enhancement

L-series attached to general Euler products

Reported by: was Owned by: was
Priority: major Milestone:
Component: number theory Keywords: sd35.5, lseries
Cc: jdemeyer Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: public/12015 (Commits, GitHub, GitLab) Commit: 0402381f95fdde81713bd36cf2713637e55a0d46
Dependencies: Stopgaps:

Status badges

Description

This summer I wrote a package for psage (see http://code.google.com/p/purplesage/source/browse/psage/lseries/eulerprod.py) that allows one to compute with L-series attached to general Euler products, and implemented many cases, included everything supported in Sage, and a lot more. This also did things that worked instead of the buggier #11631. This code is similar to the L-series package in Magma, I guess (http://magma.maths.usyd.edu.au/magma/handbook/text/1503).

It would be useful to have a stable version of this code in Sage, at least the parts that don't depend on 64-bit only stuff in psage (like smalljac). The point of this ticket is to to do that.

Attachments (2)

trac_12015-part1.patch (101.7 KB) - added by was 11 years ago.
first patch -- this implements all functionality for first version and passes all its tests. Unfortunately, the doctest coverage score is 36%. To finish this ticket, I have to get it to 100% and deal with the bugs that getting the coverage up reveals.
trac_12015-part1_updated.patch (31.9 KB) - added by cassiew1 11 years ago.

Download all attachments as: .zip

Change History (22)

Changed 11 years ago by was

first patch -- this implements all functionality for first version and passes all its tests. Unfortunately, the doctest coverage score is 36%. To finish this ticket, I have to get it to 100% and deal with the bugs that getting the coverage up reveals.

comment:1 Changed 11 years ago by kcrisman

  • Keywords sd35.5 added

Changed 11 years ago by cassiew1

comment:2 Changed 11 years ago by cassiew1

Second patch - Added a small function an, the class LSeriesTripleProduct, and some new doctests. Unfortunately, adding more code outbalanced the new doctests so the coverage is still very low. Noticed some bugs as well, such as zeros not being implemented, anlist allowing negative inputs, and taylor_series failing on some cases where it shouldn't. Much work yet to be done.

comment:3 Changed 11 years ago by was

The patch trac_12015-part1_updated.patch has some issues:

  1. It patches a file called sage/lfunctions/eulerprod_with_tripleprod.py that is not even in my patch. I'm guessing you took some old file from Sage days I had provided and started working on it. However, that has little to do with the code in the patch I posted to this ticket.
  1. Why was this change made?
            118	 	sage: K.<a> = NumberField(x^2-x-1) 
     	119	        sage: K.<a> = NumberField(x^2+1) 
    
  1. The code needs to be indented here, but isn't (in your patch):
            174	        EXAMPLES:: 
     	175	 
     	176	        sage: from sage.lfunctions.eulerprod import LSeries 
     	177	        sage: from sage.lfunctions.eulerprod import LSeriesDerivative 
     	178	        sage: K.<a>=NumberField(x^2+1) 
     	179	        sage: L=LSeries(K); L 
    
  1. Here in your patch the code is indented (good), but there is only one colon (instead of two) after EXAMPLES:
     	508	        EXAMPLES: 
     	509	 
     	510	            sage: from sage.lfunctions.eulerprod import LSeriesAbstract 
     	511	            sage: L1 = LSeriesAbstract(conductor=1, hodge_numbers=[0], weight=1, epsilon=1, poles=[1], residues=[-1], base_field=QQ) 
    

comment:4 Changed 9 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:5 Changed 9 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:6 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:7 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:8 Changed 8 years ago by tornaria

  • Branch set to u/tornaria/12015
  • Commit set to c053272e55eb3cacadd8fe6a470d71ae4a1bad12

I have made a git commit with the first patch, and also a commit updating and fixing the existing doctests. The coverage score is still 36%, though.


New commits:

d6b4ccdTrac #12015: trac_12015-part1.patch
c053272Trac #12015: fix doctests

comment:9 Changed 3 years ago by chapoton

  • Keywords lseries added
  • Milestone changed from sage-6.4 to sage-8.7

comment:10 Changed 3 years ago by embray

  • Milestone changed from sage-8.7 to sage-8.8

Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)

comment:11 Changed 3 years ago by chapoton

  • Branch changed from u/tornaria/12015 to u/chapoton/12015
  • Commit changed from c053272e55eb3cacadd8fe6a470d71ae4a1bad12 to b75bcdb7a6c38f9c6a07db8a4aec92cf65e15404

adapted to python3


New commits:

551b283Trac #12015: trac_12015-part1.patch
071acfaTrac #12015: fix doctests
67e496eupdate
b75bcdbpep cleanup

comment:12 Changed 3 years ago by git

  • Commit changed from b75bcdb7a6c38f9c6a07db8a4aec92cf65e15404 to ee16483fb37dc8e7839f1be7f585091faa01d51b

Branch pushed to git repo; I updated commit sha1. New commits:

ee16483further fixes

comment:13 Changed 3 years ago by git

  • Commit changed from ee16483fb37dc8e7839f1be7f585091faa01d51b to 349471ca6c576480a4c955c67ee5e783882cdec4

Branch pushed to git repo; I updated commit sha1. New commits:

349471csome fixes

comment:14 Changed 3 years ago by git

  • Commit changed from 349471ca6c576480a4c955c67ee5e783882cdec4 to bf103de38fa198a0d163f9bb78a1ab6be0dbd11b

Branch pushed to git repo; I updated commit sha1. New commits:

bf103deparent and element in commutative monoid

comment:15 Changed 3 years ago by git

  • Commit changed from bf103de38fa198a0d163f9bb78a1ab6be0dbd11b to 4519d3765949f91175f1da7709ca53a5955fe26b

Branch pushed to git repo; I updated commit sha1. New commits:

4519d37adding simple hash

comment:16 Changed 3 years ago by git

  • Commit changed from 4519d3765949f91175f1da7709ca53a5955fe26b to ebcdeb1864fda5fc2758ebf3f57f4da45e85958b

Branch pushed to git repo; I updated commit sha1. New commits:

ebcdeb1some detail fixes

comment:17 Changed 3 years ago by embray

  • Milestone sage-8.8 deleted

As the Sage-8.8 release milestone is pending, we should delete the sage-8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage-8.9).

comment:18 Changed 3 years ago by chapoton

  • Cc jdemeyer added

There is a pari syntax error appearing in the doctests..

comment:19 Changed 3 years ago by alexjbest

  • Branch changed from u/chapoton/12015 to public/12015
  • Commit changed from ebcdeb1864fda5fc2758ebf3f57f4da45e85958b to ed3867d53c53b23b39ede0577c4d40cf69448f06

I fixed a couple of tests that I had locally at https://github.com/alexjbest/psage . I think one major problem here still is the mix of things defined in eulerprod.py vs. dockchitser.py many functions like residues, epsilon should probably be for any dockchitser L-function if they are calling pari, with a wrapper in the LSeriesAbstract class?


New commits:

485bee1Merge branch 'u/chapoton/12015' of git://trac.sagemath.org/sage into HEAD
ed3867dsmall fixes for eulerprod

comment:20 Changed 2 months ago by git

  • Commit changed from ed3867d53c53b23b39ede0577c4d40cf69448f06 to 0402381f95fdde81713bd36cf2713637e55a0d46

Branch pushed to git repo; I updated commit sha1. New commits:

0402381Merge branch 'public/12015' in 9.7.b1
Note: See TracTickets for help on using tickets.