Opened 11 years ago

Closed 10 years ago

#12012 closed defect (fixed)

'make distclean' should clean up start.log, spkg/parallel_make.cfg

Reported by: jhpalmieri Owned by: GeorgSWeber
Priority: blocker Milestone: sage-4.8
Component: build Keywords:
Cc: jdemeyer, leif, mjo Merged in: sage-4.8.alpha3
Authors: John Palmieri Reviewers: Michael Orlitzky
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #11991, #11959 Stopgaps:

Status badges

Description (last modified by jhpalmieri)

The patch (to the root repo) removes start.log and spkg/parallel_make.cfg when you run "make distclean". It no longer removes the ipython directory.

Attachments (1)

trac_12012-distclean.patch​ (791 bytes) - added by jhpalmieri 11 years ago.
root repo

Download all attachments as: .zip

Change History (11)

comment:1 Changed 11 years ago by kini

  • Dependencies set to #11991, #11959

comment:2 Changed 11 years ago by jhpalmieri

  • Status changed from new to needs_review

comment:3 Changed 11 years ago by jhpalmieri

  • Description modified (diff)

Changed 11 years ago by jhpalmieri

root repo

comment:4 follow-up: Changed 11 years ago by jhpalmieri

  • Priority changed from major to blocker

I'm upgrading this to "blocker": running 'make distclean' shouldn't break your Sage distribution. It does now because it deletes the ipython directory. (The patch is also easy to review, I think.)

comment:5 in reply to: ↑ 4 Changed 11 years ago by jdemeyer

Replying to jhpalmieri:

It does now because it deletes the ipython directory. (The patch is also easy to review, I think.)

What exactly is the ipython directory needed for? I just deleted the ipython directory from a sage-4.8.alpha2 installation and everything still seems to work fine.

comment:6 follow-up: Changed 11 years ago by jhpalmieri

Well, if you don't have a DOT_SAGE directory, the contents from SAGE_ROOT/ipython/ are copied to DOT_SAGE/ipython when DOT_SAGE is created.

comment:7 in reply to: ↑ 6 ; follow-up: Changed 10 years ago by mjo

  • Cc mjo added

Replying to jhpalmieri:

Well, if you don't have a DOT_SAGE directory, the contents from SAGE_ROOT/ipython/ are copied to DOT_SAGE/ipython when DOT_SAGE is created.

If you've just run make distclean, how will $DOT_SAGE get created?

comment:8 in reply to: ↑ 7 ; follow-up: Changed 10 years ago by jhpalmieri

Replying to mjo:

Replying to jhpalmieri:

Well, if you don't have a DOT_SAGE directory, the contents from SAGE_ROOT/ipython/ are copied to DOT_SAGE/ipython when DOT_SAGE is created.

If you've just run make distclean, how will $DOT_SAGE get created?

I don't think I understand your question. The point of the patch here is that if you download a Sage source distribution and run make distclean, it breaks the distribution: the Sage root repository is no longer clean, and more importantly, if you have no $DOT_SAGE directory, then when you build and run Sage, it will fail when it tries to create DOT_SAGE/ipython/.

comment:9 in reply to: ↑ 8 Changed 10 years ago by mjo

  • Reviewers set to Michael Orlitzky
  • Status changed from needs_review to positive_review

Replying to jhpalmieri:

I don't think I understand your question. The point of the patch here is that if you download a Sage source distribution and run make distclean, it breaks the distribution: the Sage root repository is no longer clean, and more importantly, if you have no $DOT_SAGE directory, then when you build and run Sage, it will fail when it tries to create DOT_SAGE/ipython/.

Oh, sorry. I thought the ipython directory would be recreated after a build, and I had to make distclean and then sit through a full rebuild to see that's not the case.

I have reviewed:

  1. Confirm that spkg/parallel_make.cfg gets created/used in the following:
  • spkg/install
  • spkg/standard/deps
  1. Confirm that start.log should be removed.
  1. make distclean. Remove my ~/.sage directory. Build and try to start sage. Crashes per the ticket.

So, looks good.

comment:10 Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.8.alpha3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.