Opened 11 years ago
Closed 10 years ago
#12012 closed defect (fixed)
'make distclean' should clean up start.log, spkg/parallel_make.cfg
Reported by: | jhpalmieri | Owned by: | GeorgSWeber |
---|---|---|---|
Priority: | blocker | Milestone: | sage-4.8 |
Component: | build | Keywords: | |
Cc: | jdemeyer, leif, mjo | Merged in: | sage-4.8.alpha3 |
Authors: | John Palmieri | Reviewers: | Michael Orlitzky |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #11991, #11959 | Stopgaps: |
Description (last modified by )
The patch (to the root repo) removes start.log and spkg/parallel_make.cfg when you run "make distclean". It no longer removes the ipython directory.
Attachments (1)
Change History (11)
comment:1 Changed 11 years ago by
- Dependencies set to #11991, #11959
comment:2 Changed 11 years ago by
- Status changed from new to needs_review
comment:3 Changed 11 years ago by
- Description modified (diff)
Changed 11 years ago by
comment:4 follow-up: ↓ 5 Changed 11 years ago by
- Priority changed from major to blocker
I'm upgrading this to "blocker": running 'make distclean' shouldn't break your Sage distribution. It does now because it deletes the ipython directory. (The patch is also easy to review, I think.)
comment:5 in reply to: ↑ 4 Changed 11 years ago by
Replying to jhpalmieri:
It does now because it deletes the ipython directory. (The patch is also easy to review, I think.)
What exactly is the ipython
directory needed for? I just deleted the ipython
directory from a sage-4.8.alpha2 installation and everything still seems to work fine.
comment:6 follow-up: ↓ 7 Changed 11 years ago by
Well, if you don't have a DOT_SAGE directory, the contents from SAGE_ROOT/ipython/ are copied to DOT_SAGE/ipython when DOT_SAGE is created.
comment:7 in reply to: ↑ 6 ; follow-up: ↓ 8 Changed 10 years ago by
- Cc mjo added
Replying to jhpalmieri:
Well, if you don't have a DOT_SAGE directory, the contents from SAGE_ROOT/ipython/ are copied to DOT_SAGE/ipython when DOT_SAGE is created.
If you've just run make distclean
, how will $DOT_SAGE get created?
comment:8 in reply to: ↑ 7 ; follow-up: ↓ 9 Changed 10 years ago by
Replying to mjo:
Replying to jhpalmieri:
Well, if you don't have a DOT_SAGE directory, the contents from SAGE_ROOT/ipython/ are copied to DOT_SAGE/ipython when DOT_SAGE is created.
If you've just run
make distclean
, how will $DOT_SAGE get created?
I don't think I understand your question. The point of the patch here is that if you download a Sage source distribution and run make distclean
, it breaks the distribution: the Sage root repository is no longer clean, and more importantly, if you have no $DOT_SAGE
directory, then when you build and run Sage, it will fail when it tries to create DOT_SAGE/ipython/
.
comment:9 in reply to: ↑ 8 Changed 10 years ago by
- Reviewers set to Michael Orlitzky
- Status changed from needs_review to positive_review
Replying to jhpalmieri:
I don't think I understand your question. The point of the patch here is that if you download a Sage source distribution and run
make distclean
, it breaks the distribution: the Sage root repository is no longer clean, and more importantly, if you have no$DOT_SAGE
directory, then when you build and run Sage, it will fail when it tries to createDOT_SAGE/ipython/
.
Oh, sorry. I thought the ipython directory would be recreated after a build, and I had to make distclean
and then sit through a full rebuild to see that's not the case.
I have reviewed:
- Confirm that spkg/parallel_make.cfg gets created/used in the following:
- spkg/install
- spkg/standard/deps
- Confirm that start.log should be removed.
make distclean
. Remove my ~/.sage directory. Build and try to start sage. Crashes per the ticket.
So, looks good.
comment:10 Changed 10 years ago by
- Merged in set to sage-4.8.alpha3
- Resolution set to fixed
- Status changed from positive_review to closed
root repo