Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#12009 closed defect (fixed)

optional package gnuplotpy-1.8.spkg causes test failure on sage-4.7.2

Reported by: mariah Owned by: tbd
Priority: major Milestone: sage-5.1
Component: interfaces Keywords: sd40.5
Cc: Merged in: sage-5.1.beta6
Authors: Mike Hansen Reviewers: Douglas McNeil, Karl-Dieter Crisman
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

sage-4.7.2 with the optional package gnuplotpy-1.8.spkg installed causes the following test failure:

% ./sage -t -long -force_lib "devel/sage/sage/tests/startup.py"
sage -t -long -force_lib "devel/sage/sage/tests/startup.py" 
**********************************************************************
File "/home/mariah/sage/sage-4.7.2-x86_64-Linux-core2-fc-optional/devel/sage/sage/tests/startup.py", line 13:
    sage: sage0("'numpy' in sys.modules")
Expected:
    False
Got:
    True
**********************************************************************
1 items had failures:
   1 of   5 in __main__.example_0
***Test Failed*** 1 failures.
For whitespace errors, see the file /home/mariah/.sage//tmp/startup_30568.py
         [8.0 s]
 
----------------------------------------------------------------------
The following tests failed:


        sage -t -long -force_lib "devel/sage/sage/tests/startup.py"
Total time for all tests: 8.1 seconds
%

Attachments (1)

trac_12009.patch (1.2 KB) - added by mhansen 7 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by mhansen

  • Authors set to Mike Hansen
  • Status changed from new to needs_review

comment:2 Changed 7 years ago by dsm

Works for me: applies cleanly against 5.1.beta0 and passes the tests afterwards.

comment:3 Changed 7 years ago by kcrisman

Mike,

This looks like the right fix, efficient as always, and Doug tested it. Should we at this point make the attribute a single-underscore one instead of double-underscore?

Changed 7 years ago by mhansen

comment:4 Changed 7 years ago by mhansen

  • Keywords sd40.5 added

I just went ahead and made the double underscore into a single one. Positive review?

comment:5 Changed 7 years ago by kcrisman

  • Reviewers set to Douglas S. McNeil, Karl-Dieter Crisman
  • Status changed from needs_review to positive_review

Great!

comment:6 Changed 7 years ago by jdemeyer

  • Component changed from optional packages to interfaces

comment:7 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.1.beta6
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:8 Changed 7 years ago by jdemeyer

  • Reviewers changed from Douglas S. McNeil, Karl-Dieter Crisman to Douglas McNeil, Karl-Dieter Crisman
Note: See TracTickets for help on using tickets.