#12006 closed defect (fixed)
sage-4.8 and magma-2.18 not playing well together
Reported by: | Mariah Lennox | Owned by: | William Stein |
---|---|---|---|
Priority: | major | Milestone: | sage-5.0 |
Component: | interfaces | Keywords: | |
Cc: | Merged in: | sage-5.0.beta4 | |
Authors: | William Stein | Reviewers: | Marco Streng |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Running
./sage -t -only-optional=magma devel/sage/sage
on a recent build of sage-4.7.2 where magma-2.17-13 (recent release) is installed (skynet/eno) gives the following errors:
The following tests failed: sage -t -only-optional=magma "devel/sage/sage/rings/polynomial/multi_polynomial.pyx" sage -t -only-optional=magma "devel/sage/sage/interfaces/magma.py" sage -t -only-optional=magma "devel/sage/sage/schemes/elliptic_curves/ell_generic.py" sage -t -only-optional=magma "devel/sage/sage/schemes/plane_conics/con_field.py"
Apply trac_12006.2.patch
Attachments (2)
Change History (13)
comment:1 Changed 11 years ago by
Summary: | sage-4.7.2 and magma-2.17-13 not playing well together → sage-4.8 and magma-2.18 not playing well together |
---|
Changed 11 years ago by
Attachment: | trac_12006.patch added |
---|
comment:2 Changed 11 years ago by
Status: | new → needs_review |
---|
comment:3 Changed 11 years ago by
Authors: | → william stein |
---|
comment:4 Changed 11 years ago by
comment:5 Changed 11 years ago by
Your new patch is a superset of my patch, which has been needs_review for 7 weeks :(. I guess I'll have mine closed as duplicate then.
comment:6 Changed 11 years ago by
Apparently my Magma version V2.17-9 is not high enough for reviewing your patch. But the version-independent failures (like '1/1') should be fixed as soon as possible.
comment:7 follow-up: 8 Changed 11 years ago by
Reviewers: | → Marco Streng |
---|---|
Status: | needs_review → needs_work |
The test added to sage/rings/number_field/number_field_element.pyx is incorrect: 'c' is not defined, and "optional - magma" is missing.
Changed 11 years ago by
Attachment: | trac_12006.2.patch added |
---|
differs from previous patch in exactly one letter "c" --> "a"
comment:8 follow-up: 9 Changed 11 years ago by
Status: | needs_work → needs_review |
---|
Replying to mstreng:
The test added to sage/rings/number_field/number_field_element.pyx is incorrect: 'c' is not defined,
I've posted a new patch with it changed to 'a'
and "optional - magma" is missing.
The test doesn't actually require magma (all it does is raise an exception), so it is not marked optional.
comment:9 Changed 11 years ago by
Description: | modified (diff) |
---|---|
Status: | needs_review → positive_review |
comment:10 Changed 11 years ago by
Merged in: | → sage-5.0.beta4 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
comment:11 Changed 11 years ago by
Authors: | william stein → William Stein |
---|
This looks like it has a huge overlap with #12154.