Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#12006 closed defect (fixed)

sage-4.8 and magma-2.18 not playing well together

Reported by: mariah Owned by: was
Priority: major Milestone: sage-5.0
Component: interfaces Keywords:
Cc: Merged in: sage-5.0.beta4
Authors: William Stein Reviewers: Marco Streng
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by mstreng)

Running

./sage -t -only-optional=magma devel/sage/sage

on a recent build of sage-4.7.2 where magma-2.17-13 (recent release) is installed (skynet/eno) gives the following errors:

The following tests failed:


        sage -t -only-optional=magma "devel/sage/sage/rings/polynomial/multi_polynomial.pyx"
        sage -t -only-optional=magma "devel/sage/sage/interfaces/magma.py"
        sage -t -only-optional=magma "devel/sage/sage/schemes/elliptic_curves/ell_generic.py"
        sage -t -only-optional=magma "devel/sage/sage/schemes/plane_conics/con_field.py"

Apply trac_12006.2.patch

Attachments (2)

trac_12006.patch (7.9 KB) - added by was 9 years ago.
trac_12006.2.patch (7.9 KB) - added by was 9 years ago.
differs from previous patch in exactly one letter "c" --> "a"

Download all attachments as: .zip

Change History (13)

comment:1 Changed 9 years ago by was

  • Summary changed from sage-4.7.2 and magma-2.17-13 not playing well together to sage-4.8 and magma-2.18 not playing well together

Changed 9 years ago by was

comment:2 Changed 9 years ago by was

  • Status changed from new to needs_review

comment:3 Changed 9 years ago by was

  • Authors set to william stein

comment:4 Changed 9 years ago by mstreng

This looks like it has a huge overlap with #12154.

comment:5 Changed 9 years ago by mstreng

Your new patch is a superset of my patch, which has been needs_review for 7 weeks :(. I guess I'll have mine closed as duplicate then.

comment:6 Changed 9 years ago by mstreng

Apparently my Magma version V2.17-9 is not high enough for reviewing your patch. But the version-independent failures (like '1/1') should be fixed as soon as possible.

comment:7 follow-up: Changed 9 years ago by mstreng

  • Reviewers set to Marco Streng
  • Status changed from needs_review to needs_work

The test added to sage/rings/number_field/number_field_element.pyx is incorrect: 'c' is not defined, and "optional - magma" is missing.

Changed 9 years ago by was

differs from previous patch in exactly one letter "c" --> "a"

comment:8 in reply to: ↑ 7 ; follow-up: Changed 9 years ago by was

  • Status changed from needs_work to needs_review

Replying to mstreng:

The test added to sage/rings/number_field/number_field_element.pyx is incorrect: 'c' is not defined,

I've posted a new patch with it changed to 'a'

and "optional - magma" is missing.

The test doesn't actually require magma (all it does is raise an exception), so it is not marked optional.

comment:9 in reply to: ↑ 8 Changed 9 years ago by mstreng

  • Description modified (diff)
  • Status changed from needs_review to positive_review

Replying to was:

The test doesn't actually require magma

:)

comment:10 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.0.beta4
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:11 Changed 9 years ago by jdemeyer

  • Authors changed from william stein to William Stein
Note: See TracTickets for help on using tickets.