Opened 8 years ago

Closed 8 years ago

Last modified 4 years ago

#11971 closed defect (fixed)

get_memory_usage() doctest failure

Reported by: jdemeyer Owned by: mvngu
Priority: minor Milestone: sage-4.8
Component: doctest coverage Keywords:
Cc: justin Merged in: sage-4.8.alpha2
Authors: Jeroen Demeyer Reviewers: Justin Walker
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by chapoton)

Justin reports on sage-release:

Built from scratch on Mac OS X, 10.6.8 (Dual 6-Core Xeon) w/o problems.  Testing (ptestlong) yielded one failure:
----------------------------------------------------------------------
The temporary doctesting directory
   /Users/justin/.sage/tmp/Zippo.local-33453
was not removed: it is not empty, presumably because doctests
failed or doctesting was interrupted.

----------------------------------------------------------------------

The following tests failed:

sage -t  -long -force_lib devel/sage/sage/misc/getusage.py # 1 doctests failed
----------------------------------------------------------------------
**********************************************************************
File "/Users/Sage/sage-4.7.2.rc1/devel/sage-main/sage/misc/getusage.py", line 93
:
    sage: get_memory_usage(t)          # amount of memory more than when we defined t.
Expected:
    0.0
Got:
    0.25
**********************************************************************

Attachments (1)

11971_getrusage.patch (2.4 KB) - added by jdemeyer 8 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 8 years ago by leif

EXAMPLES: should now be EXAMPLES:: (i.e., with a double-colon).

The program names (prstat and top etc.) should be typeset in monospaced / typewriter font, i.e. for example ``prstat`` instead of 'prstat'.

Changed 8 years ago by jdemeyer

comment:2 Changed 8 years ago by leif

Ok, new patch looks good (although I'd also use ``t`` instead of `t`, since it is a Python identifier rather than some mathematical variable or symbol), but Justin should test it and give it positive review.

comment:3 Changed 8 years ago by leif

P.S.: FWIW, applies to rc0 and passes tests on Ubuntu 10.04.3 x86_64.

comment:4 Changed 8 years ago by justin

  • Summary changed from get_memory_usage() doctest failure to get_memory_usage() doctest failure (positive_review)

I can't now reproduce the doctest failure; maybe cosmic rays are to blame.

In any case, the doctests all pass with the patch applied; the changes seem reasonable.

comment:5 Changed 8 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Priority changed from blocker to minor
  • Reviewers set to Justin Walker
  • Status changed from new to needs_review

comment:6 Changed 8 years ago by jdemeyer

  • Status changed from needs_review to positive_review
  • Summary changed from get_memory_usage() doctest failure (positive_review) to get_memory_usage() doctest failure

comment:7 Changed 8 years ago by jdemeyer

  • Merged in set to sage-4.8.alpha2
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:8 Changed 4 years ago by chapoton

  • Description modified (diff)
Note: See TracTickets for help on using tickets.