Opened 11 years ago

Closed 10 years ago

#11933 closed defect (fixed)

Fix qepcad doctests

Reported by: jdemeyer Owned by: jdemeyer
Priority: minor Milestone: sage-4.8
Component: doctest coverage Keywords:
Cc: jason Merged in: sage-4.8.alpha4
Authors: Jeroen Demeyer Reviewers: Karl-Dieter Crisman
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

This patch fixes some doctest failures for the experimental package qepcad and also fixes the formatting of the doctests.

This is only tested on x86_64 Linux (I tried installing on 32-bit i386 Linux but that failed).

Attachments (1)

11933.patch (54.9 KB) - added by jdemeyer 11 years ago.

Download all attachments as: .zip

Change History (11)

Changed 11 years ago by jdemeyer

comment:1 Changed 11 years ago by jason

  • Cc jason added

comment:2 Changed 11 years ago by jason

Can you mark this "needs review" if it is?

comment:3 Changed 11 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Status changed from new to needs_review

comment:4 Changed 11 years ago by jdemeyer

  • Owner changed from mvngu to jdemeyer

Yes, it is ready for review. I have only tested this on one system, I hope the results are not system-dependent.

comment:5 follow-up: Changed 11 years ago by jdemeyer

This patch fixes some doctest failures for the experimental package qepcad and also fixes the formatting of the doctests.

This is only tested on x86_64 Linux (I tried installing on 32-bit i386 Linux but that failed).

comment:6 Changed 11 years ago by jdemeyer

  • Description modified (diff)

comment:7 Changed 11 years ago by jdemeyer

  • Milestone sage-4.7.3 deleted

Milestone sage-4.7.3 deleted

comment:8 in reply to: ↑ 5 Changed 10 years ago by kcrisman

  • Milestone set to sage-4.8
  • Reviewers set to Karl-Dieter Crisman

Replying to jdemeyer:

This patch fixes some doctest failures for the experimental package qepcad and also fixes the formatting of the doctests.

As far as I can tell, the nonsubstantive changes are all fine, with the possible exception of the bullet lists toward the end, which could conceivably not be at an appropriate indentation level. This is not in the reference manual, so I can't check that, but the other changes you made are good, and I assume that the bullets will render properly.

This is only tested on x86_64 Linux (I tried installing on 32-bit i386 Linux but that failed).

It also failed on Mac OS X 10.6.

I'll try to test this on sage.math momentarily for the term order changes, then it could go to positive review.

comment:9 Changed 10 years ago by kcrisman

  • Status changed from needs_review to positive_review

On sage.math, before:

sage -t -optional "devel/sage/sage/interfaces/qepcad.py"    
**********************************************************************
File "/mnt/usb1/scratch/kcrisman/sage-4.8.alpha3-sage.math.washington.edu-x86_64-Linux/devel/sage/sage/interfaces/qepcad.py", line 95:
    sage: F = qf.exactly_k(3, y, circle * ellipse == 0); F    # optional - qepcad
Expected:
    (X3 y)[(y^2 + x^2 - 3) (y^2 + 2 x y + y + 3 x^2 - x - 7) = 0]
Got:
    (X3 y)[(x^2 + y^2 - 3) (3 x^2 + 2 x y + y^2 - x + y - 7) = 0]
<snip>
Expected:
    'approx-precision N\n\nApproximate algebraic numbers to N decimal places.\n'
Got:
    'approx-precision N\n\nApproximate algeraic numbers to N decimal places.\n'
**********************************************************************
3 items had failures:
   6 of  61 in __main__.example_0
   1 of   6 in __main__.example_2
   1 of   6 in __main__.example_25
***Test Failed*** 8 failures.
For whitespace errors, see the file /home/kcrisman/.sage//tmp/qepcad_31669.py
	 [11.3 s]
 
----------------------------------------------------------------------
The following tests failed:


	sage -t -optional "devel/sage/sage/interfaces/qepcad.py"
Total time for all tests: 11.4 seconds

After:

sage -t -optional "devel/sage/sage/interfaces/qepcad.py"    
	 [11.6 s]
 
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 11.6 seconds

Great!

comment:10 Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.8.alpha4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.