Opened 9 years ago

Closed 8 years ago

#11931 closed defect (duplicate)

Fix all element classes should take the parent as first mandatory argument.

Reported by: nthiery Owned by: nthiery
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: categories Keywords:
Cc: sage-combinat Merged in:
Authors: Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Taken from Sets.ParentMethods?._element_constructor_from_element_class:

            Caveat: ``self`` is passed to the constructor of the
            element class as a keyword argument ``parent``. Many
            element classes in Sage, in particular those implemented
            by mean of extension types, take ``parent`` as first
            mandatory argument instead.

            This incompatibility will be fixed soon (Fall 2009?) by
            having all element classes take ``parent`` as first
            mandatory argument, and updating this default
            implementation of :meth:`_element_constructor_`.

Fall 2009 is long over ...

Change History (4)

comment:1 Changed 9 years ago by jdemeyer

  • Milestone sage-4.7.3 deleted

Milestone sage-4.7.3 deleted

comment:2 Changed 8 years ago by tscrim

  • Milestone set to sage-duplicate/invalid/wontfix
  • Reviewers set to Travis Scrimshaw
  • Status changed from new to needs_review

This was taken care of in #14519.

comment:3 Changed 8 years ago by mhansen

  • Status changed from needs_review to positive_review

Sounds good.

comment:4 Changed 8 years ago by jdemeyer

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.