Opened 8 years ago

Closed 8 years ago

#11927 closed enhancement (fixed)

option degree_sequence for graphs

Reported by: dimpase Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-4.8
Component: graph theory Keywords:
Cc: kini, ncohen, jpang Merged in: sage-4.8.alpha2
Authors: Hiroto Mulia, John Pang Reviewers: Dmitrii Pasechnik
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by kini)

graphs() has an option deg_seq, which is not a pretty name (a newbie can easily miss its meaning), and moreover is the only abbreviated option. Let us call it degree_sequence, and deprecate deg_seq.


Apply trac_11927-degree-sequence.2.patch

Attachments (2)

trac_11927-degree-sequence.patch (4.7 KB) - added by hirotowu 8 years ago.
trac_11927-degree-sequence.2.patch (4.9 KB) - added by kini 8 years ago.
apply to $SAGE_ROOT/devel/sage

Download all attachments as: .zip

Change History (18)

comment:1 Changed 8 years ago by kini

  • Cc kini added

comment:2 Changed 8 years ago by ncohen

  • Cc ncohen added

comment:3 Changed 8 years ago by kini

  • Cc jpang added
  • Description modified (diff)

comment:4 Changed 8 years ago by ncohen

(by the way, if sombody here plays with degree sequences, I wrote a long patch about them at #11584. I don't remember whether I advertised that one much :-D)

Changed 8 years ago by hirotowu

comment:5 Changed 8 years ago by dimpase

  • Status changed from new to needs_review

positive review -- this is a minor change, and cleanly implemented, too.

comment:6 Changed 8 years ago by dimpase

  • Status changed from needs_review to positive_review

comment:7 Changed 8 years ago by jdemeyer

  • Authors set to Hiroto Mulia
  • Reviewers set to Dmitrii Pasechnik

comment:8 Changed 8 years ago by kini

  • Authors changed from Hiroto Mulia to Hiroto Mulia, John Pang

comment:9 Changed 8 years ago by jdemeyer

  • Milestone sage-4.7.3 deleted

Milestone sage-4.7.3 deleted

comment:10 Changed 8 years ago by jdemeyer

  • Milestone set to sage-4.8
  • Status changed from positive_review to needs_work

This should be rebased to sage-4.7.2:

patching file sage/graphs/graph_generators.py
Hunk #1 FAILED at 278.
Hunk #2 succeeded at 311 (offset 9 lines).
Hunk #3 succeeded at 466 (offset 23 lines).
Hunk #4 succeeded at 6383 (offset 23 lines).
Hunk #5 succeeded at 6430 (offset 23 lines).
Hunk #6 succeeded at 6861 (offset 23 lines).
1 out of 6 hunks FAILED -- saving rejects to file sage/graphs/graph_generators.py.rej

comment:11 Changed 8 years ago by kini

OK, rebasing to 4.8.alpha1.

Changed 8 years ago by kini

apply to $SAGE_ROOT/devel/sage

comment:12 Changed 8 years ago by kini

  • Description modified (diff)
  • Status changed from needs_work to needs_review

comment:13 Changed 8 years ago by kini

  • Description modified (diff)

... whoops

comment:14 Changed 8 years ago by jdemeyer

  • Status changed from needs_review to positive_review

Usually, if all you did was an obvious rebase, then you can set back positive_review yourself.

comment:15 Changed 8 years ago by kini

Noted, thanks.

comment:16 Changed 8 years ago by jdemeyer

  • Merged in set to sage-4.8.alpha2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.