Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#11901 closed defect (fixed)

Fix more noise on MacOS X 10.4 PPC

Reported by: leif Owned by: jason, was
Priority: minor Milestone: sage-4.7.2
Component: linear algebra Keywords: noisy zero epsilon threshold polynomial term
Cc: kcrisman, rbeezer Merged in: sage-4.7.2.alpha4
Authors: Leif Leonhardy Reviewers: Karl-Dieter Crisman, Rob Beezer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by leif)

This is a follow-up to #7852 (and #11897).

As reported on sage-release, some doctests in Sage 4.7.2.alpha3 still failed on a PowerPC running MacOS X 10.4 due to numerical noise (or slightly different behaviour, giving correct but varying results).

The patch here further increases the threshold for noisy zero terms of polynomials slightly.


Apply

  1. trac_11901-adjust_threshold_for_noisy_zero_terms_in_polynomial_element.patch

to the Sage library.

Attachments (1)

trac_11901-adjust_threshold_for_noisy_zero_terms_in_polynomial_element.patch (967 bytes) - added by leif 10 years ago.
Sage library patch. Based on Sage 4.7.2.alpha3 / #7852.

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by leif

Sage library patch. Based on Sage 4.7.2.alpha3 / #7852.

comment:1 Changed 10 years ago by leif

  • Authors set to Leif Leonhardy
  • Cc kcrisman rbeezer added
  • Description modified (diff)
  • Status changed from new to needs_review

A single-character patch to be tested (by "student") and reviewed...

comment:2 Changed 10 years ago by rbeezer

This looks good to me, but I think we need to see if it does the job on Mac PowerPC?

comment:3 Changed 10 years ago by kcrisman

  • Reviewers set to Karl-Dieter Crisman, Rob Beezer
  • Status changed from needs_review to positive_review

I know this is sort of silly, but it is nice to have all tests pass :)

Works fine.

sage -t -long "devel/sage/sage/rings/polynomial/polynomial_element.pyx"
         [156.8 s]
 
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 157.4 seconds

comment:4 follow-up: Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.7.2.alpha4
  • Resolution set to fixed
  • Status changed from positive_review to closed

Thanks!

comment:5 in reply to: ↑ 4 ; follow-up: Changed 10 years ago by leif

Replying to jdemeyer:

Thanks!

So Moufang is still alive?

comment:6 in reply to: ↑ 5 Changed 10 years ago by jdemeyer

Replying to leif:

So Moufang is still alive?

Of course. Did I ever say it wasn't? I don't actually use this machine, only to test Sage.

Note: See TracTickets for help on using tickets.