Changes between Version 9 and Version 10 of Ticket #11890


Ignore:
Timestamp:
10/11/11 07:53:16 (9 years ago)
Author:
lftabera
Comment:

The solution here to test the use of nffactor is more elegant than in #10910 and with these patches there are no known failing cases. All doctest pases on sage-4.7.2-alpha3 + #11130 + #11891

I give a positive review to Jeroen's patches but I add a patch that needs review with a couple of things:

-On a complicated case we show that the discriminant is not fully factored by trial division.

-The second example is a test case that shows that we really need the new version of Pari in #11130 this case will fail with older versions of Pari (See Pari bug pari bug #1207)

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11890

    • Property Reviewers changed from to Luis Felipe Tabera Alonso
  • Ticket #11890 – Description

    v9 v10  
    1111See also #10910.
    1212
    13 '''Apply''' [attachment:11890.patch] and [attachment:11890_try_nffactor.patch].
     13'''Apply''' [attachment:11890.patch], [attachment:11890_try_nffactor.patch] and [attachment:11890_reviewer.patch].