Changes between Version 16 and Version 19 of Ticket #11880


Ignore:
Timestamp:
03/06/12 12:29:43 (8 years ago)
Author:
ncohen
Comment:

Hi Nathann,

Wow !! This patch's almost good ! GREAAAAAAAAT ! :-)

I just went back through the patches (I folded them on the Sage-Combinat queue: trac_11880-isgci-all_in_one-nc.patch). I added a reviewer patch adding a bit of doc, and using the shorter syntax for links, and using further cached methods.

I saw that... Thank you very much !

  • doc coverage:

Argggg... Ok, it's now fixed :-)

  • I am not sure about the name of the method show since for other Sage objects, this opens a plot.

Then I made the mistake twice, as the MixedIntegerLinearProgram? object also have a .show() method that does not plot anything. Though you are right, perhaps the name "show" is not descriptive enough... What would you think of graph_classes.Chordal.description() to obtain the same information ? :-)

  • I have not retested _download_db and friends

I have not modified them. Actually, since I reinstalled Sage since the last time I worked on this patch I obtained an error the first time I ran isgci, and I fixed it by running graph_classes.update_db() :-)

Nathann

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11880 – Description

    v16 v19  
    3131    * [attachment:trac_11880-moving_methods.patch]
    3232    * [attachment:trac_11880-object_oriented.patch]
     33    * [attachment:trac_11880-isgci-more-review-nt.patch]
     34    * [attachment:trac_11880-documentation.patch]
    3335
    3436Add to SAGE_ROOT/data/graphs/: