Changes between Version 15 and Version 16 of Ticket #11880


Ignore:
Timestamp:
02/20/12 18:55:47 (8 years ago)
Author:
ncohen
Comment:

Hellooooooo !!

With this new patch the class works again. It is not totally "object-oriented", and way nicer. Nicolas : I believe I addressed all of your remarks except one :

# TODO: or systematically use the user's version if it exists,
# throwing a warning if it is not the most recent?

This TODO appears in the part of the code that loads "the most recent" version of the database. Why would you want to only load the user's version instead of the most recent one ? I thought that this way all users may benefit from a global update...

About returning to the user the exception raised by a wrong access to a file I did not know what to do exactly. There is nothing wrong going on if the user cannot write to the system-wide database, so this exception is still caught. On the other hand he should be able to write to his own DOT_SAGE folder, so in this second case the code does not catch the exception anymore.

Well... I think that's all I had to say :-)

Nathann

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11880

    • Property Status changed from needs_work to needs_review
  • Ticket #11880 – Description

    v15 v16  
    2929    * [attachment:trac_11880-graph_classes-review-nt.patch]
    3030    * [attachment:trac_11880-first_review.patch]
    31     * [attachment:trac_11880-moving_functions.patch]
     31    * [attachment:trac_11880-moving_methods.patch]
     32    * [attachment:trac_11880-object_oriented.patch]
    3233
    3334Add to SAGE_ROOT/data/graphs/: