Opened 11 years ago

Closed 11 years ago

#11876 closed defect (fixed)

Subfields should store embedding

Reported by: Jeroen Demeyer Owned by: David Loeffler
Priority: major Milestone: sage-4.7.2
Component: number fields Keywords:
Cc: Marco Streng Merged in: sage-4.7.2.alpha4
Authors: Jeroen Demeyer Reviewers: Marco Streng
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

If K is a number field with a given embedding, then K.subfield(gen) should inherit that embedding but it does not::

sage: K.<a> = NumberField(x^2-5, embedding=2)
sage: L, phi = K.subfield(-a)
sage: K.specified_complex_embedding()
Generic morphism:
  From: Number Field in a with defining polynomial x^2 - 5
  To:   Real Lazy Field
  Defn: a -> 2.236067977499790?
sage: L.specified_complex_embedding()

Also, if K has no given embedding, then L could at least store an embedding in K.

Attachments (1)

11876.patch (2.9 KB) - added by Jeroen Demeyer 11 years ago.

Download all attachments as: .zip

Change History (5)

Changed 11 years ago by Jeroen Demeyer

Attachment: 11876.patch added

comment:1 Changed 11 years ago by Jeroen Demeyer

Cc: Marco Streng added
Status: newneeds_review

comment:2 Changed 11 years ago by Marco Streng

Status: needs_reviewpositive_review

comment:3 Changed 11 years ago by Marco Streng

Authors: Jeroen Demeyer
Reviewers: Marco Streng

comment:4 Changed 11 years ago by Jeroen Demeyer

Merged in: sage-4.7.2.alpha4
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.