Changes between Version 1 and Version 2 of Ticket #11866


Ignore:
Timestamp:
Sep 28, 2011, 8:39:01 PM (11 years ago)
Author:
John Palmieri
Comment:

This looks good and it works in my (brief) testing. See #10822 and #11790 for patches which already include this particular fix. It's probably easiest to get this one merged, and then rebase the others with respect to this one. But if you use zsh, I would be happy to hear your input on #10822.

I think that since it seems to work, and since we came up with the same change completely independently, this can be given a positive review.

(Note that the "scripts" repository and the "root" repository are different. This should be applied to the scripts repository. I've changed the ticket description to clarify this.)

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11866

    • Property Status changed from needs_review to positive_review
    • Property Reviewers changed from to John Palmieri
    • Property Priority changed from major to minor
  • Ticket #11866 – Description

    v1 v2  
    2929The attached patch fixes this.
    3030
    31 '''Apply''' [attachment:trac11866_proper_zsh_prompt.patch] to the root/scripts directory, not the normal Sage repository.
     31'''Apply''' [attachment:trac11866_proper_zsh_prompt.patch] to the scripts repository, not the normal Sage repository.