Opened 11 years ago
Last modified 3 years ago
#11841 closed enhancement
Generates Quadratic Lattice — at Version 15
Reported by:  annahaensch  Owned by:  justin 

Priority:  minor  Milestone:  sageduplicate/invalid/wontfix 
Component:  quadratic forms  Keywords:  
Cc:  Merged in:  
Authors:  Anna Haensch  Reviewers:  Aly Deines, Sarah Chisholm 
Report Upstream:  N/A  Work issues:  
Branch:  u/chapoton/11841  Commit:  e9a13d23eff0d71a72126678db4e36b0b7fb3625 
Dependencies:  #11863  Stopgaps: 
Description (last modified by )
This function take a list of vectors, L, and a quadratic Lattice, M. It returns a new lattice with the underlying space QQM but spanned by the vectors L.
Change History (18)
Changed 11 years ago by
comment:1 Changed 9 years ago by
 Dependencies set to #11863
 Status changed from new to needs_review
 Type changed from PLEASE CHANGE to enhancement
comment:2 Changed 9 years ago by
The patch bilinear_map.patch comes from the ticket #11863. So, I have listed that as a dependency for the patch for the convenience of the reviewers.
comment:3 Changed 9 years ago by
instruction for the patchbot:
apply Trac_11841.patch
comment:4 Changed 9 years ago by
 Description modified (diff)
Here is a new clean patch, to be used as a starting point for future discussion.
for the bot:
apply trac_11841_sub_lattice.patch
Changed 9 years ago by
comment:5 Changed 9 years ago by
apply trac_11841_sub_lattice.patch
comment:6 Changed 9 years ago by
 Milestone changed from sage5.11 to sage5.12
comment:7 Changed 8 years ago by
 Branch set to u/chapoton/11841
 Commit set to 1160803d62e6f730205f3de80fc1d37edb7e566c
New commits:
1160803  trac #11841 sub lattice of a given lattice

comment:8 Changed 8 years ago by
 Reviewers set to Aly Deines
 Status changed from needs_review to positive_review
comment:9 Changed 8 years ago by
 Reviewers changed from Aly Deines to Aly Deines, Sarah Chisholm
 Status changed from positive_review to needs_work
There is a little confusion in the description  should you say: determines the quadratic form and not lattice?
comment:10 followup: ↓ 11 Changed 8 years ago by
 Milestone changed from sage6.1 to sage6.2
comment:11 in reply to: ↑ 10 Changed 8 years ago by
 Status changed from needs_work to needs_review
 Summary changed from Generates Quadratic Forms to Generates Quadratic Lattice
It only determines lattices, , in fact, if the "new basis" element doesn't give an integral lattice, and error message is raised. So this best fix would be changing the ticket name to "Generates Quadratic Lattice."
comment:12 Changed 8 years ago by
 Milestone changed from sage6.2 to sage6.3
comment:13 Changed 8 years ago by
 Commit changed from 1160803d62e6f730205f3de80fc1d37edb7e566c to e9a13d23eff0d71a72126678db4e36b0b7fb3625
comment:14 Changed 8 years ago by
 Milestone changed from sage6.3 to sage6.4
comment:15 Changed 7 years ago by
 Description modified (diff)
put on top of bilinear_map.patch