Opened 10 years ago

Closed 2 years ago

#11841 closed enhancement (duplicate)

Generates Quadratic Lattice

Reported by: annahaensch Owned by: justin
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: quadratic forms Keywords:
Cc: Merged in:
Authors: Anna Haensch Reviewers: Simon Brandhorst
Report Upstream: N/A Work issues: doc
Branch: u/jdemeyer/11841 (Commits, GitHub, GitLab) Commit: e035f625e71a1abcde82394da30325541600c9bb
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

This function take a list of vectors, L, and a quadratic Lattice, M. It returns a new lattice with the underlying space QQM but spanned by the vectors L.

Attachments (3)

Trac_11841.patch (2.9 KB) - added by annahaensch 10 years ago.
put on top of bilinear_map.patch
bilinear_map.patch (1.9 KB) - added by annahaensch 10 years ago.
add this first
trac_11841_sub_lattice.patch (3.4 KB) - added by chapoton 9 years ago.

Download all attachments as: .zip

Change History (23)

Changed 10 years ago by annahaensch

put on top of bilinear_map.patch

Changed 10 years ago by annahaensch

add this first

comment:1 Changed 9 years ago by knsam

  • Dependencies set to #11863
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to enhancement

comment:2 Changed 9 years ago by knsam

The patch bilinear_map.patch comes from the ticket #11863. So, I have listed that as a dependency for the patch for the convenience of the reviewers.

comment:3 Changed 9 years ago by chapoton

instruction for the patchbot:

apply Trac_11841.patch

comment:4 Changed 9 years ago by chapoton

  • Description modified (diff)

Here is a new clean patch, to be used as a starting point for future discussion.

for the bot:

apply trac_11841_sub_lattice.patch

Changed 9 years ago by chapoton

comment:5 Changed 9 years ago by chapoton

apply trac_11841_sub_lattice.patch

comment:6 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:7 Changed 8 years ago by chapoton

  • Branch set to u/chapoton/11841
  • Commit set to 1160803d62e6f730205f3de80fc1d37edb7e566c

New commits:

1160803trac #11841 sub lattice of a given lattice

comment:8 Changed 8 years ago by aly.deines

  • Reviewers set to Aly Deines
  • Status changed from needs_review to positive_review

comment:9 Changed 8 years ago by schisholm

  • Reviewers changed from Aly Deines to Aly Deines, Sarah Chisholm
  • Status changed from positive_review to needs_work

There is a little confusion in the description -- should you say: determines the quadratic form and not lattice?

comment:10 follow-up: Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:11 in reply to: ↑ 10 Changed 8 years ago by annahaensch

  • Status changed from needs_work to needs_review
  • Summary changed from Generates Quadratic Forms to Generates Quadratic Lattice

It only determines lattices, , in fact, if the "new basis" element doesn't give an integral lattice, and error message is raised. So this best fix would be changing the ticket name to "Generates Quadratic Lattice."

comment:12 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:13 Changed 7 years ago by git

  • Commit changed from 1160803d62e6f730205f3de80fc1d37edb7e566c to e9a13d23eff0d71a72126678db4e36b0b7fb3625

Branch pushed to git repo; I updated commit sha1. New commits:

c13c3f1Merge branch 'u/chapoton/11841' of ssh://trac.sagemath.org:22/sage into 11841
e9a13d2trac #11841 minor details (formatting)

comment:14 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:15 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:16 Changed 6 years ago by jdemeyer

  • Branch changed from u/chapoton/11841 to u/jdemeyer/11841

comment:17 Changed 6 years ago by jdemeyer

  • Commit changed from e9a13d23eff0d71a72126678db4e36b0b7fb3625 to e035f625e71a1abcde82394da30325541600c9bb
  • Dependencies #11863 deleted

Rebased.


New commits:

fc0f531trac #11841 sub lattice of a given lattice
e035f62trac #11841 minor details (formatting)

comment:18 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-6.4 to sage-6.8
  • Status changed from needs_review to needs_work
  • Work issues set to doc

I'm having a hard time understanding what this means:

Determines the quadratic lattice spanned by the vectors in `L`
with the same underlying quadratic space as the lattice given.

especially because the output is a quadratic form and not a lattice.

comment:19 Changed 2 years ago by sbrandhorst

  • Milestone changed from sage-6.8 to sage-duplicate/invalid/wontfix
  • Status changed from needs_work to needs_review
sage: QuadraticForm(matrix(ZZ,2,[2,1,1,2]))
Quadratic form in 2 variables over Integer Ring with coefficients: 
[ 1 1 ]
[ * 1 ]
sage: qf = QuadraticForm(matrix(ZZ,2,[2,1,1,2]))
sage: matrix(ZZ,2,[1,1,0,1])
[1 1]
[0 1]
sage: t = matrix(ZZ,2,[1,1,0,1])
sage: qf(t)
Quadratic form in 2 variables over Integer Ring with coefficients: 
[ 1 3 ]
[ * 3 ]

The functionality already exists.

comment:20 Changed 2 years ago by chapoton

  • Resolution set to duplicate
  • Reviewers changed from Aly Deines, Sarah Chisholm to Simon Brandhorst
  • Status changed from needs_review to closed
Note: See TracTickets for help on using tickets.