Opened 10 years ago

Last modified 7 years ago

#11823 new enhancement

add Weierstrass cubic curve class

Reported by: katestange Owned by: cremona
Priority: major Milestone: sage-6.4
Component: elliptic curves Keywords: singular, weierstrass form
Cc: aly.deines, ekin, katestange, jmypark Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by katestange)

Add cubic Weierstrass curve class, which can initialize either an elliptic curve or a singular cubic. Implement basic functionality for singular cubic curves, such as: change of Weierstrass form, addition of points, etc.

Attachments (7)

trac_11823_singular_elliptic_curves.patch (8.8 KB) - added by aly.deines 10 years ago.
Replaces previous
trac_11823_singular_elliptic_curves.2.patch (9.8 KB) - added by jmypark 10 years ago.
replaces previous patch
trac_11823_singular_weierstrass_curves_class.patch (226.9 KB) - added by katestange 10 years ago.
replace previous (now a class, not a flag)
trac_11823.patch (344.2 KB) - added by aly.deines 10 years ago.
Replaces previous patch
Trac_11823.patch (344.7 KB) - added by katestange 10 years ago.
replace previous
Trac_11823.2.patch (337.4 KB) - added by katestange 10 years ago.
replaces previous
Trac_11823.3.patch (385.1 KB) - added by katestange 10 years ago.
Replaces previous

Download all attachments as: .zip

Change History (19)

comment:1 Changed 10 years ago by ekin

  • Cc ekin added

comment:2 Changed 10 years ago by katestange

  • Cc katestange added

Changed 10 years ago by aly.deines

Replaces previous

comment:3 Changed 10 years ago by jmypark

  • Cc jmypark added

Changed 10 years ago by jmypark

replaces previous patch

Changed 10 years ago by katestange

replace previous (now a class, not a flag)

Changed 10 years ago by aly.deines

Replaces previous patch

comment:4 Changed 10 years ago by aly.deines

Instead of setting a flag, we have a new class WeierstrassCubic? which handles both EllipticCurves? and SingularWeierstrassCurves?.

Changed 10 years ago by katestange

replace previous

comment:5 Changed 10 years ago by katestange

  • Description modified (diff)
  • Summary changed from add singular cubics to EllipticCurve class to add Weierstrass cubic curve class

comment:6 Changed 10 years ago by katestange

  • Description modified (diff)

Changed 10 years ago by katestange

replaces previous

Changed 10 years ago by katestange

Replaces previous

comment:7 follow-up: Changed 9 years ago by vbraun

Do you have any plans for this ticket? Is it finished, needs work, abandoned?

Having a WeierstrassCubic class hierarchy sounds like a good idea but it needs to be integrated.

Also, right now its one huge patch bomb. It would be nice if it could be split into manageable pieces, for example start with WeierstrassCubic_generic only and then build on top of that.

comment:8 in reply to: ↑ 7 Changed 9 years ago by cremona

Replying to vbraun:

Do you have any plans for this ticket? Is it finished, needs work, abandoned?

Who is "you"?

Having a WeierstrassCubic class hierarchy sounds like a good idea but it needs to be integrated.

That's a necessary condition, certainly.

Also, right now its one huge patch bomb. It would be nice if it could be split into manageable pieces, for example start with WeierstrassCubic_generic only and then build on top of that.

I myself don't need this. I'm also worried that since elliptic curves would be a special case, this would add a new layer of code for all elliptic curves, slowing them down, which would be a Bad Thing.

Anyway, it's up to the people who worked on this in the frst place to make their case!

comment:9 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:10 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:11 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:12 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4
Note: See TracTickets for help on using tickets.