Opened 10 years ago
Last modified 7 years ago
#11823 new enhancement
add Weierstrass cubic curve class
Reported by: | katestange | Owned by: | cremona |
---|---|---|---|
Priority: | major | Milestone: | sage-6.4 |
Component: | elliptic curves | Keywords: | singular, weierstrass form |
Cc: | aly.deines, ekin, katestange, jmypark | Merged in: | |
Authors: | Reviewers: | ||
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Add cubic Weierstrass curve class, which can initialize either an elliptic curve or a singular cubic. Implement basic functionality for singular cubic curves, such as: change of Weierstrass form, addition of points, etc.
Attachments (7)
Change History (19)
comment:1 Changed 10 years ago by
- Cc ekin added
comment:2 Changed 10 years ago by
- Cc katestange added
Changed 10 years ago by
comment:3 Changed 10 years ago by
- Cc jmypark added
comment:4 Changed 10 years ago by
Instead of setting a flag, we have a new class WeierstrassCubic? which handles both EllipticCurves? and SingularWeierstrassCurves?.
comment:5 Changed 10 years ago by
- Description modified (diff)
- Summary changed from add singular cubics to EllipticCurve class to add Weierstrass cubic curve class
comment:6 Changed 10 years ago by
- Description modified (diff)
comment:7 follow-up: ↓ 8 Changed 9 years ago by
Do you have any plans for this ticket? Is it finished, needs work, abandoned?
Having a WeierstrassCubic
class hierarchy sounds like a good idea but it needs to be integrated.
Also, right now its one huge patch bomb. It would be nice if it could be split into manageable pieces, for example start with WeierstrassCubic_generic
only and then build on top of that.
comment:8 in reply to: ↑ 7 Changed 9 years ago by
Replying to vbraun:
Do you have any plans for this ticket? Is it finished, needs work, abandoned?
Who is "you"?
Having a
WeierstrassCubic
class hierarchy sounds like a good idea but it needs to be integrated.
That's a necessary condition, certainly.
Also, right now its one huge patch bomb. It would be nice if it could be split into manageable pieces, for example start with
WeierstrassCubic_generic
only and then build on top of that.
I myself don't need this. I'm also worried that since elliptic curves would be a special case, this would add a new layer of code for all elliptic curves, slowing them down, which would be a Bad Thing.
Anyway, it's up to the people who worked on this in the frst place to make their case!
comment:9 Changed 8 years ago by
- Milestone changed from sage-5.11 to sage-5.12
comment:10 Changed 7 years ago by
- Milestone changed from sage-6.1 to sage-6.2
comment:11 Changed 7 years ago by
- Milestone changed from sage-6.2 to sage-6.3
comment:12 Changed 7 years ago by
- Milestone changed from sage-6.3 to sage-6.4
Replaces previous