Opened 10 years ago

Closed 9 years ago

#11822 closed enhancement (fixed)

Wraps E.reduction(p)(P) so you can call P.reduction(p)

Reported by: aly.deines Owned by: cremona
Priority: minor Milestone: sage-5.0
Component: elliptic curves Keywords: elliptic curves, reduction sd35.5
Cc: katestange Merged in: sage-5.0.beta1
Authors: Aly Deines Reviewers: William Stein, Cassie Williams, Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

Given an elliptic curve E with a point P and good reduction at p, this wraps E.reduction(p)(P) to P.reduction(p).

Apply trac_11822_elliptic_curve_point_reduction.patch

Attachments (2)

trac_11822.patch (1.9 KB) - added by was 10 years ago.
fixes and adds documentation
trac_11822_elliptic_curve_point_reduction.patch (3.0 KB) - added by jdemeyer 9 years ago.
Fixed doc formatting, apply only this

Download all attachments as: .zip

Change History (18)

comment:1 Changed 10 years ago by katestange

  • Cc katestange added

comment:2 Changed 10 years ago by katestange

  • Status changed from new to needs_review

Changed 10 years ago by was

fixes and adds documentation

comment:3 Changed 10 years ago by was

  • Status changed from needs_review to positive_review

The docstring was misformated (see http://wstein.org/home/wstein/tmp/trac11822.png). I've refreshed the patch and uploaded a fixed one. Positive review.

comment:4 Changed 10 years ago by davidloeffler

  • Reviewers set to William Stein

comment:5 Changed 10 years ago by katestange

It might be nice to have a doc example of the type

E = EllipticCurve(...)
P = E(...)
E.reduction(p).is_on_curve(P.reduction(p))
True

comment:6 Changed 10 years ago by katestange

  • Status changed from positive_review to needs_work

I added one line doctest to check that the reduction of the point is on the reduction of the curve. It probably needs_review again now, but I can't seem to set that flag.

comment:7 Changed 10 years ago by katestange

  • Status changed from needs_work to needs_review

comment:8 Changed 10 years ago by jdemeyer

  • Milestone sage-4.7.3 deleted

Milestone sage-4.7.3 deleted

comment:9 Changed 9 years ago by cassiew1

  • Keywords sd35.5 added
  • Milestone set to sage-5.0
  • Reviewers changed from William Stein to William Stein, Cassie Williams

comment:10 Changed 9 years ago by cassiew1

  • Status changed from needs_review to positive_review

Checked functionality in Sage, seems to be working as advertised. Positive review.

comment:11 Changed 9 years ago by cassiew1

Sorry for the extra comment. Forgot to mention that the doctest passed 100% and the documentation looks good.

comment:12 Changed 9 years ago by jdemeyer

  • Description modified (diff)

comment:13 Changed 9 years ago by jdemeyer

  • Status changed from positive_review to needs_work

Please fix the formatting of the documentation string to be consistent with the developer manual: there should be an empty line after INPUT and no indent (currently, there is a 1-space indent).

Changed 9 years ago by jdemeyer

Fixed doc formatting, apply only this

comment:14 Changed 9 years ago by jdemeyer

  • Status changed from needs_work to needs_review

comment:15 Changed 9 years ago by jdemeyer

  • Reviewers changed from William Stein, Cassie Williams to William Stein, Cassie Williams, Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:16 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.0.beta1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.