Opened 11 years ago

Closed 11 years ago

#11822 closed enhancement (fixed)

Wraps E.reduction(p)(P) so you can call P.reduction(p)

Reported by: Alyson Deines Owned by: John Cremona
Priority: minor Milestone: sage-5.0
Component: elliptic curves Keywords: elliptic curves, reduction sd35.5
Cc: Kate Stange Merged in: sage-5.0.beta1
Authors: Aly Deines Reviewers: William Stein, Cassie Williams, Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

Given an elliptic curve E with a point P and good reduction at p, this wraps E.reduction(p)(P) to P.reduction(p).

Apply trac_11822_elliptic_curve_point_reduction.patch

Attachments (2)

trac_11822.patch (1.9 KB) - added by William Stein 11 years ago.
fixes and adds documentation
trac_11822_elliptic_curve_point_reduction.patch (3.0 KB) - added by Jeroen Demeyer 11 years ago.
Fixed doc formatting, apply only this

Download all attachments as: .zip

Change History (18)

comment:1 Changed 11 years ago by Kate Stange

Cc: Kate Stange added

comment:2 Changed 11 years ago by Kate Stange

Status: newneeds_review

Changed 11 years ago by William Stein

Attachment: trac_11822.patch added

fixes and adds documentation

comment:3 Changed 11 years ago by William Stein

Status: needs_reviewpositive_review

The docstring was misformated (see http://wstein.org/home/wstein/tmp/trac11822.png). I've refreshed the patch and uploaded a fixed one. Positive review.

comment:4 Changed 11 years ago by David Loeffler

Reviewers: William Stein

comment:5 Changed 11 years ago by Kate Stange

It might be nice to have a doc example of the type

E = EllipticCurve(...)
P = E(...)
E.reduction(p).is_on_curve(P.reduction(p))
True

comment:6 Changed 11 years ago by Kate Stange

Status: positive_reviewneeds_work

I added one line doctest to check that the reduction of the point is on the reduction of the curve. It probably needs_review again now, but I can't seem to set that flag.

comment:7 Changed 11 years ago by Kate Stange

Status: needs_workneeds_review

comment:8 Changed 11 years ago by Jeroen Demeyer

Milestone: sage-4.7.3

Milestone sage-4.7.3 deleted

comment:9 Changed 11 years ago by Cassie Williams

Keywords: sd35.5 added
Milestone: sage-5.0
Reviewers: William SteinWilliam Stein, Cassie Williams

comment:10 Changed 11 years ago by Cassie Williams

Status: needs_reviewpositive_review

Checked functionality in Sage, seems to be working as advertised. Positive review.

comment:11 Changed 11 years ago by Cassie Williams

Sorry for the extra comment. Forgot to mention that the doctest passed 100% and the documentation looks good.

comment:12 Changed 11 years ago by Jeroen Demeyer

Description: modified (diff)

comment:13 Changed 11 years ago by Jeroen Demeyer

Status: positive_reviewneeds_work

Please fix the formatting of the documentation string to be consistent with the developer manual: there should be an empty line after INPUT and no indent (currently, there is a 1-space indent).

Changed 11 years ago by Jeroen Demeyer

Fixed doc formatting, apply only this

comment:14 Changed 11 years ago by Jeroen Demeyer

Status: needs_workneeds_review

comment:15 Changed 11 years ago by Jeroen Demeyer

Reviewers: William Stein, Cassie WilliamsWilliam Stein, Cassie Williams, Jeroen Demeyer
Status: needs_reviewpositive_review

comment:16 Changed 11 years ago by Jeroen Demeyer

Merged in: sage-5.0.beta1
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.