Opened 8 years ago

Last modified 7 years ago

#11763 closed enhancement

Parents for polyhedra — at Version 9

Reported by: vbraun Owned by: mhampton
Priority: major Milestone: sage-5.6
Component: geometry Keywords:
Cc: robertwb Merged in:
Authors: Volker Braun Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #11634 Stopgaps:

Description (last modified by davidloeffler)

The Polyhedron class is, so far, free-standing with some sort of coercion for the base ring tacked manually. This ticket strives to add parents for polyhedra and make the base ring coercion work more naturally.

There will be 3 supported base rings:

  • ZZ (meaning that the polyhedron is a lattice polytope, that is, both H- and V-representation are defined over ZZ)
  • QQ
  • RDF

Apply:

Change History (15)

comment:1 Changed 8 years ago by novoselt

Would there be any benefit in supporting real fields of arbitrary precision?

comment:2 Changed 8 years ago by vbraun

We don't have an implementation of the double description algorithm for other base rings, so we wouldn't be able to compute anything.

Changed 8 years ago by vbraun

Initial patch

Changed 8 years ago by vbraun

Initial patch

comment:3 Changed 8 years ago by vbraun

  • Authors set to Volker Braun
  • Description modified (diff)
  • Status changed from new to needs_review

This is now ready for inclusion. Marshall, are you interested in reviewing this patch and its dependency? ;-)

comment:4 Changed 8 years ago by vbraun

  • Description modified (diff)

comment:5 Changed 8 years ago by vbraun

Fix comparison of H/V-representation objects:

sage: triangle = Polyhedron([(0,0), (1,0), (0,1)])
sage: ieq = triangle.inequality_generator().next()
sage: ieq == copy(ieq)
False

Now returns True, as it should.

Changed 8 years ago by vbraun

Updated patch

Changed 8 years ago by davidloeffler

Rebased for new patch at 11634

Changed 8 years ago by davidloeffler

Rebased for new patch at #11634

comment:6 Changed 8 years ago by davidloeffler

  • Description modified (diff)

The new patch I posted at #11634 broke these, so I rebased them.

Apply trac_11763_ZZ_polyhedron-rebase.patch, trac_11763_parents-rebase.patch

comment:7 Changed 8 years ago by davidloeffler

Apply trac_11763_zz_polyhedron-rebase.patch, trac_11763_parents-rebase.patch

(bloody patchbot!)

comment:8 Changed 8 years ago by davidloeffler

No matter what I do, the patchbot won't pick up the two patches above, so I've done a single qfolded patch. Hopefully this will now work!

comment:9 Changed 8 years ago by davidloeffler

  • Description modified (diff)

Changed 8 years ago by davidloeffler

Apply only this patch. Patch against 5.0.beta7

Note: See TracTickets for help on using tickets.