Opened 11 years ago

Last modified 11 years ago

#11761 closed enhancement

Upgrade Cython to 0.15.1 — at Version 18

Reported by: Robert Bradshaw Owned by: tbd
Priority: major Milestone: sage-4.8
Component: packages: standard Keywords:
Cc: François Bissey, Jean-Pierre Flori Merged in:
Authors: Robert Bradshaw Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Change History (21)

comment:1 in reply to:  description Changed 11 years ago by Leif Leonhardy

Replying to robertwb:

... including generators.

Yeah!

Changed 11 years ago by Robert Bradshaw

Attachment: 11761-cython-0.15.patch added

comment:2 Changed 11 years ago by Robert Bradshaw

Status: newneeds_review

comment:3 Changed 11 years ago by François Bissey

Cc: François Bissey added

comment:4 Changed 11 years ago by Jean-Pierre Flori

Cc: Jean-Pierre Flori added

comment:5 Changed 11 years ago by Robert Bradshaw

Note that 0.15.1 is around the corner, but it's not as big of a jump.

comment:6 Changed 11 years ago by Leif Leonhardy

Authors: Robert Bradshaw
Description: modified (diff)

Would 0.15.1 require additional changes to Sage?

comment:7 Changed 11 years ago by Jason Grout

Just FYI, 0.15.1 is now released.

comment:8 in reply to:  7 ; Changed 11 years ago by Leif Leonhardy

Replying to jason:

Just FYI, 0.15.1 is now released.

Oh, did you tell Robert?

(Although he said "it's not as big of a jump".)

comment:9 in reply to:  8 ; Changed 11 years ago by Jason Grout

Replying to leif:

Replying to jason:

Just FYI, 0.15.1 is now released.

Oh, did you tell Robert?

Oh, I'm sure he knows, since he's the BFDL for Cython, if there is such a position ;).

(Although he said "it's not as big of a jump".)

comment:10 in reply to:  9 Changed 11 years ago by Leif Leonhardy

Replying to jason:

Replying to leif:

Replying to jason:

Just FYI, 0.15.1 is now released.

Oh, did you tell Robert?

Oh, I'm sure he knows, since he's the BFDL for Cython, if there is such a position ;).

I was just kidding.

(Wonder whether he updates the spkg... :P)

comment:11 Changed 11 years ago by Leif Leonhardy

Summary: Upgrade Cython to 0.15Upgrade Cython to 0.15 or later

:)

comment:12 Changed 11 years ago by Robert Bradshaw

Description: modified (diff)
Summary: Upgrade Cython to 0.15 or laterUpgrade Cython to 0.15.1

No further patches needed for 0.15.1.

Changed 11 years ago by Jeroen Demeyer

comment:13 Changed 11 years ago by Jeroen Demeyer

Description: modified (diff)
Milestone: sage-4.7.2sage-4.7.3

Changed 11 years ago by Jeroen Demeyer

Attachment: cython-0.15.1.diff added

Diff for the new Cython spkg, for review only

comment:14 Changed 11 years ago by Jeroen Demeyer

Minor comment: spkg-install is not executable (I know it is made executable upon building, but better fix this in the spkg anyway).

comment:15 Changed 11 years ago by Jeroen Demeyer

Description: modified (diff)

comment:16 Changed 11 years ago by Jeroen Demeyer

Status: needs_reviewneeds_work

Why is the directory tests missing from the Cython source? This should either be fixed, or be documented.

comment:17 Changed 11 years ago by Jeroen Demeyer

What should be done with:

cdef mpz_t denom
mpz_init_set_si(denom, 1)

This code is correct but gives a local variable 'denom' referenced before assignment warning. (there are many of these in sage/matrix/misc.pyx for example)

comment:18 Changed 11 years ago by Jeroen Demeyer

Description: modified (diff)
Reviewers: Jeroen Demeyer
Note: See TracTickets for help on using tickets.