Opened 10 years ago

Last modified 10 years ago

#11761 closed enhancement

Upgrade Cython to 0.15.1 — at Version 18

Reported by: robertwb Owned by: tbd
Priority: major Milestone: sage-4.8
Component: packages: standard Keywords:
Cc: fbissey, jpflori Merged in:
Authors: Robert Bradshaw Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Change History (21)

comment:1 in reply to: ↑ description Changed 10 years ago by leif

Replying to robertwb:

... including generators.

Yeah!

Changed 10 years ago by robertwb

comment:2 Changed 10 years ago by robertwb

  • Status changed from new to needs_review

comment:3 Changed 10 years ago by fbissey

  • Cc fbissey added

comment:4 Changed 10 years ago by jpflori

  • Cc jpflori added

comment:5 Changed 10 years ago by robertwb

Note that 0.15.1 is around the corner, but it's not as big of a jump.

comment:6 Changed 10 years ago by leif

  • Authors set to Robert Bradshaw
  • Description modified (diff)

Would 0.15.1 require additional changes to Sage?

comment:7 follow-up: Changed 10 years ago by jason

Just FYI, 0.15.1 is now released.

comment:8 in reply to: ↑ 7 ; follow-up: Changed 10 years ago by leif

Replying to jason:

Just FYI, 0.15.1 is now released.

Oh, did you tell Robert?

(Although he said "it's not as big of a jump".)

comment:9 in reply to: ↑ 8 ; follow-up: Changed 10 years ago by jason

Replying to leif:

Replying to jason:

Just FYI, 0.15.1 is now released.

Oh, did you tell Robert?

Oh, I'm sure he knows, since he's the BFDL for Cython, if there is such a position ;).

(Although he said "it's not as big of a jump".)

comment:10 in reply to: ↑ 9 Changed 10 years ago by leif

Replying to jason:

Replying to leif:

Replying to jason:

Just FYI, 0.15.1 is now released.

Oh, did you tell Robert?

Oh, I'm sure he knows, since he's the BFDL for Cython, if there is such a position ;).

I was just kidding.

(Wonder whether he updates the spkg... :P)

comment:11 Changed 10 years ago by leif

  • Summary changed from Upgrade Cython to 0.15 to Upgrade Cython to 0.15 or later

:)

comment:12 Changed 10 years ago by robertwb

  • Description modified (diff)
  • Summary changed from Upgrade Cython to 0.15 or later to Upgrade Cython to 0.15.1

No further patches needed for 0.15.1.

Changed 10 years ago by jdemeyer

comment:13 Changed 10 years ago by jdemeyer

  • Description modified (diff)
  • Milestone changed from sage-4.7.2 to sage-4.7.3

Changed 10 years ago by jdemeyer

Diff for the new Cython spkg, for review only

comment:14 Changed 10 years ago by jdemeyer

Minor comment: spkg-install is not executable (I know it is made executable upon building, but better fix this in the spkg anyway).

comment:15 Changed 10 years ago by jdemeyer

  • Description modified (diff)

comment:16 Changed 10 years ago by jdemeyer

  • Status changed from needs_review to needs_work

Why is the directory tests missing from the Cython source? This should either be fixed, or be documented.

comment:17 Changed 10 years ago by jdemeyer

What should be done with:

cdef mpz_t denom
mpz_init_set_si(denom, 1)

This code is correct but gives a local variable 'denom' referenced before assignment warning. (there are many of these in sage/matrix/misc.pyx for example)

comment:18 Changed 10 years ago by jdemeyer

  • Description modified (diff)
  • Reviewers set to Jeroen Demeyer
Note: See TracTickets for help on using tickets.