Opened 10 years ago
Closed 9 years ago
#11744 closed defect (fixed)
Add library gmp needed for real interval absolute
| Reported by: | kcrisman | Owned by: | tbd |
|---|---|---|---|
| Priority: | major | Milestone: | sage-4.7.2 |
| Component: | porting: Cygwin | Keywords: | |
| Cc: | robertwb | Merged in: | sage-4.7.2.alpha3 |
| Authors: | Karl-Dieter Crisman | Reviewers: | Mike Hansen |
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
Status badges
Description (last modified by )
Cygwin fails on the new file introduced in #9180. We need
libraries = ['gmp']
in that extension in module_list.py for this to build properly.
Apply trac_11744.patch to the Sage library.
Attachments (1)
Change History (8)
comment:1 Changed 10 years ago by
Changed 10 years ago by
comment:2 Changed 10 years ago by
- Cc robertwb added
- Status changed from new to needs_review
Ready for review! I guess we COULD wait until someone actually tests this on Cygwin, or perhaps the author of #9180 could confirm that gmpz things need to be defined for said pyx file to compile properly. Anyway, ready for review :)
comment:3 Changed 10 years ago by
- Reviewers set to Mike Hansen
- Status changed from needs_review to positive_review
From the code at #9180, it's clear that it requires GMP. Looks good to me.
comment:4 follow-up: ↓ 5 Changed 10 years ago by
Thanks for taking care of this oversight.
comment:5 in reply to: ↑ 4 Changed 10 years ago by
Replying to robertwb:
Thanks for taking care of this oversight.
My pleasure - it was nice to find something I could actually fix for once! Thanks to Mike having shown me the way at Days 31 on a similar ticket.
You can make it up by reviewing #11119, which should be very easy to finish off :) Or even by checking that the links in #11245 are hard (should be enough to finish the review), and/or checking the spkg construction in #11497, etc. It would be so nice to just be able to type "make" and only have to fix the build at Maxima. Then we just have to figure out #11551 and #9167... not to mention that now my Win 7 computer fails at importing sage.misc.random, before it even gets to initializing I, which is new to me...
comment:6 Changed 9 years ago by
- Description modified (diff)
comment:7 Changed 9 years ago by
- Merged in set to sage-4.7.2.alpha3
- Resolution set to fixed
- Status changed from positive_review to closed
See #11499 for type of patch needed.