Opened 8 years ago

Closed 8 years ago

#11733 closed enhancement (worksforme)

do not load sagenb.misc.misc on startup

Reported by: saraedum Owned by: jason, mpatel, was
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: notebook Keywords: sd32
Cc: Merged in:
Authors: Reviewers: Julian Rueth
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #11732 Stopgaps:

Description (last modified by leif)

Not loading sagenb.misc.misc on normal sage startup speeds up sage startup:

$ dumbbench -- ./sage --startuptime
Ran 25 iterations (4 outliers).
Rounded run time per iteration: 9.80e-01 +/- 1.3e-02 (1.3%)

vs.

dumbbench -- ./sage --startuptime
Ran 21 iterations (1 outliers).
Rounded run time per iteration: 9.38e-01 +/- 1.5e-02 (1.6%)

Apply:

  1. trac_11733_sagenb_misc_misc_sage.patch to the Sage library.
  2. trac_11733_sagenb_misc_misc_sagenb.patch to the SageNB repository.

Attachments (2)

trac_11733_sagenb_misc_misc_sage.patch (1.1 KB) - added by saraedum 8 years ago.
trac_11733_sagenb_misc_misc_sagenb.patch (8.5 KB) - added by saraedum 8 years ago.

Download all attachments as: .zip

Change History (16)

Changed 8 years ago by saraedum

Changed 8 years ago by saraedum

comment:1 Changed 8 years ago by saraedum

  • Status changed from new to needs_review

comment:2 Changed 8 years ago by saraedum

  • Authors changed from Julian Rüth to Julian Rueth

comment:3 Changed 8 years ago by was

  • Keywords sd32 added

comment:4 Changed 8 years ago by robertwb

  • Status changed from needs_review to positive_review

Looks good. Wish it were a bigger spedup, but ever 1-2% counts (it's like compound interest ;-)

comment:5 follow-up: Changed 8 years ago by leif

  • Description modified (diff)
  • Reviewers set to Robert Bradshaw
  • Status changed from positive_review to needs_work

Does not apply to Sage 4.7.2.alpha2 / SageNB 0.8.21.

Also, please make use of the comment fields for attachments.

comment:6 in reply to: ↑ 5 ; follow-up: Changed 8 years ago by leif

Replying to leif:

Does not apply to Sage 4.7.2.alpha2 / SageNB 0.8.21.

Sorry, missed the dependency. Going to retry...

comment:7 in reply to: ↑ 6 Changed 8 years ago by leif

Replying to leif:

Replying to leif:

Does not apply to Sage 4.7.2.alpha2 / SageNB 0.8.21.

Sorry, missed the dependency. Going to retry...

Still does not apply:

applying http://trac.sagemath.org/sage_trac/raw-attachment/ticket/11733/trac_11733_sagenb_misc_misc_sagenb.patch
patching file sagenb/misc/misc.py
Hunk #1 succeeded at 106 (offset 2 lines).
Hunk #2 FAILED at 163
Hunk #3 succeeded at 168 (offset -11 lines).
Hunk #4 FAILED at 334
Hunk #5 FAILED at 351
3 out of 5 hunks FAILED -- saving rejects to file sagenb/misc/misc.py.rej
patching file sagenb/notebook/interact.py
patching file sagenb/notebook/notebook.py
Hunk #1 succeeded at 30 with fuzz 2 (offset 0 lines).
Hunk #2 succeeded at 619 (offset 5 lines).
Hunk #3 succeeded at 1592 with fuzz 1 (offset -2 lines).
patching file sagenb/notebook/run_notebook.py
abort: patch failed to apply

comment:8 Changed 8 years ago by leif

  • Work issues set to Rebase on Sage 4.7.2.alpha2.

comment:9 follow-up: Changed 8 years ago by saraedum

  • Milestone changed from sage-4.7.2 to sage-duplicate/invalid/wontfix

the sagenb.misc.misc import is faster in the latest alpha and it's harder to get rid of it now, so I guess it's not worth it anymore.

comment:10 in reply to: ↑ 9 Changed 8 years ago by leif

Replying to saraedum:

the sagenb.misc.misc import is faster in the latest alpha and it's harder to get rid of it now, so I guess it's not worth it anymore.

Are you referring to alpha2 or the alpha3 prerelease?

Anyway, I can close this ticket if you give it "positive review" in the sense that it is invalid / fixed / no longer worth doing.

comment:11 Changed 8 years ago by leif

  • Status changed from needs_work to needs_info

comment:12 Changed 8 years ago by saraedum

  • Status changed from needs_info to needs_review

no longer worth doing.

comment:13 Changed 8 years ago by saraedum

  • Status changed from needs_review to positive_review

comment:14 Changed 8 years ago by leif

  • Authors Julian Rueth deleted
  • Resolution set to worksforme
  • Reviewers changed from Robert Bradshaw to Julian Rueth
  • Status changed from positive_review to closed
  • Work issues Rebase on Sage 4.7.2.alpha2. deleted
Note: See TracTickets for help on using tickets.