Opened 10 years ago
Closed 10 years ago
#11722 closed enhancement (fixed)
document the SAGE_PARALLEL_SPKG_BUILD environment variable
Reported by: | mderickx | Owned by: | mvngu |
---|---|---|---|
Priority: | minor | Milestone: | sage-4.7.2 |
Component: | documentation | Keywords: | sd32 |
Cc: | Merged in: | sage-4.7.2.alpha3 | |
Authors: | Maarten Derickx | Reviewers: | Simon Spicer, John Palmieri |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
It's very useful in speeding up building but isn't documented anywhere!
Apply:
to the Sage root repository.
Attachments (3)
Change History (14)
Changed 10 years ago by
comment:1 Changed 10 years ago by
- Status changed from new to needs_review
comment:2 Changed 10 years ago by
comment:3 Changed 10 years ago by
- Priority changed from major to minor
- Reviewers set to Simon Spicer
One minor typo ('ammount' -> 'amount'), fixed in the new patch. Otherwise looks good.
comment:4 Changed 10 years ago by
- Status changed from needs_review to positive_review
comment:5 Changed 10 years ago by
- Keywords sd32 added
comment:6 Changed 10 years ago by
- Reviewers changed from Simon Spicer to Simon Spicer, John Palmieri
- Status changed from positive_review to needs_work
This variable is not documented nowhere: it's in the installation guide. But I agree that it's a good idea to put it in the top-level README, also.
A few comments: in other parts of the README file, we use "spkg" instead of "SPKG". Also, at the end of line 182, the word "the" should be deleted. I think we should also mention that using SAGE_CHECK=yes
almost always causes a failure when building Python. I've attached a referee patch making all of these changes. (Sorry for the length of the first chunk: it just adds the phrase "spkg" stands for "Sage package"
, but then the linebreaks for the paragraph needed reworking.)
comment:7 Changed 10 years ago by
- Status changed from needs_work to needs_review
Only the referee patch needs review.
comment:8 Changed 10 years ago by
- Description modified (diff)
comment:9 Changed 10 years ago by
- Status changed from needs_review to positive_review
Looks ok to me :)
comment:10 Changed 10 years ago by
- Description modified (diff)
Setting MAKE
without setting SAGE_PARALLEL_SPKG_BUILD=yes
can (currently) have strange effects, so in principle one shouldn't set one without setting the other.
-j
is an option to GNU make
, which isn't mentioned in the README.txt
at all. (Sage is unlikely to build with any other make
.)
Btw, SAGE_PARALLEL_SPKG_BUILD
is documented in the Sage Installation Guide, which is referenced from the README.txt
, though not prominently.
Also, the Sage library is built in parallel even if MAKE
is not set (which I consider a bug).
Cf. #11622.
comment:11 Changed 10 years ago by
- Merged in set to sage-4.7.2.alpha3
- Resolution set to fixed
- Status changed from positive_review to closed
apply to root repository