Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#11721 closed defect (fixed)

Silent failures in matrix code

Reported by: rbeezer Owned by: jason, was
Priority: minor Milestone: sage-4.8
Component: linear algebra Keywords: beginner, sd32
Cc: jason Merged in: sage-4.8.alpha2
Authors: Rob Beezer Reviewers: Johan Bosman
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by rbeezer)

If you call rows() for a matrix and supply a bad argument, it just goes on its way.

sage: A = matrix(QQ, 2, range(4))
sage: A.rows(1)
[(0, 1), (2, 3)]

Same for columns.

A request for a Jordan block of negative size just goes on its way.

sage: jordan_block(6.2, -8)
[]

Also - some general clean-up while I was in the area.

Apply:

  1. trac_11721-matrix-arguments.patch

Attachments (1)

trac_11721-matrix-arguments.patch (5.1 KB) - added by rbeezer 10 years ago.

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by rbeezer

comment:1 Changed 10 years ago by rbeezer

  • Authors set to Rob Beezer
  • Description modified (diff)
  • Keywords beginner added
  • Status changed from new to needs_review

comment:2 Changed 10 years ago by rbeezer

  • Keywords sd32 added

comment:3 Changed 10 years ago by johanbosman

  • Reviewers set to Johan Bosman
  • Status changed from needs_review to positive_review

Looks okay and passes all tests. :).

comment:4 Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.8.alpha2
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:5 Changed 10 years ago by jason

  • Cc jason added

comment:6 Changed 10 years ago by rbeezer

Johan,

Just back after being away for a while. Thanks for the review!

Rob

Note: See TracTickets for help on using tickets.