Opened 10 years ago

Closed 8 years ago

#11719 closed defect (fixed)

Add is_monomial() to power series and laurent series ring elements

Reported by: boothby Owned by: malb
Priority: minor Milestone: sage-6.3
Component: commutative algebra Keywords: sd32, laurent series, power series
Cc: Merged in:
Authors: Tom Boothby, Ralf Stephan Reviewers: Peter Bruin
Report Upstream: N/A Work issues:
Branch: c3851c0 (Commits, GitHub, GitLab) Commit: c3851c0f6a79d049ea5efc43a50359fe5a70ca08
Dependencies: Stopgaps:

Status badges

Description (last modified by boothby)

It should be trivial to check if a power/laurent series ring element is a monomial or not. It is not.

Attachments (1)

trac_11719.patch (3.6 KB) - added by boothby 10 years ago.

Download all attachments as: .zip

Change History (17)

comment:1 Changed 10 years ago by boothby

  • Description modified (diff)

comment:2 Changed 10 years ago by boothby

  • Status changed from new to needs_review

comment:3 Changed 10 years ago by boothby

  • Description modified (diff)
  • Status changed from needs_review to needs_work
  • Summary changed from Add is_monomial() to power series ring elements to Add is_monomial() to power series and laurent series ring elements

comment:4 Changed 10 years ago by boothby

  • Keywords sd32 added

Changed 10 years ago by boothby

comment:5 Changed 10 years ago by boothby

  • Status changed from needs_work to needs_review

comment:6 Changed 10 years ago by boothby

  • Authors set to Tom Boothby

comment:7 Changed 10 years ago by boothby

  • Dependencies set to #11726

comment:8 Changed 10 years ago by was

  • Status changed from needs_review to needs_work

Needs work, due to #11747 -- ambiguity of is_monomial.

comment:9 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:10 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:11 Changed 8 years ago by chapoton

  • Keywords laurent series power series added

comment:12 Changed 8 years ago by rws

  • Branch set to u/rws/add_is_monomial___to_power_series_and_laurent_series_ring_elements

comment:13 Changed 8 years ago by rws

  • Authors changed from Tom Boothby to Tom Boothby, Ralf Stephan
  • Commit set to c3851c0f6a79d049ea5efc43a50359fe5a70ca08
  • Dependencies #11726 deleted
  • Status changed from needs_work to needs_review

Rebased on 6.2.beta8. I changed the implementation of LaurentPolynomial.is_monomial because it gave the wrong (in the sense of #11747) result. It would also have marked zero as a monomial which would be wrong IMHO, and not according to Polynomial.is_monomial. I also changed the documentation to fit #11747. I removed the words non-negative from the doc of the laurent_polynomial.pyx implementation. I finally fixed appearances of "Returns".


New commits:

c3851c011719: add is_monomial to power series and Laurent poly and series

comment:14 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:15 Changed 8 years ago by pbruin

  • Reviewers set to Peter Bruin
  • Status changed from needs_review to positive_review

Looks good and the patchbot is happy.

comment:16 Changed 8 years ago by vbraun

  • Branch changed from u/rws/add_is_monomial___to_power_series_and_laurent_series_ring_elements to c3851c0f6a79d049ea5efc43a50359fe5a70ca08
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.