Opened 11 years ago

Closed 9 years ago

#11719 closed defect (fixed)

Add is_monomial() to power series and laurent series ring elements

Reported by: Kelly Boothby Owned by: Martin Albrecht
Priority: minor Milestone: sage-6.3
Component: commutative algebra Keywords: sd32, laurent series, power series
Cc: Merged in:
Authors: Tom Boothby, Ralf Stephan Reviewers: Peter Bruin
Report Upstream: N/A Work issues:
Branch: c3851c0 (Commits, GitHub, GitLab) Commit: c3851c0f6a79d049ea5efc43a50359fe5a70ca08
Dependencies: Stopgaps:

Status badges

Description (last modified by Kelly Boothby)

It should be trivial to check if a power/laurent series ring element is a monomial or not. It is not.

Attachments (1)

trac_11719.patch (3.6 KB) - added by Kelly Boothby 11 years ago.

Download all attachments as: .zip

Change History (17)

comment:1 Changed 11 years ago by Kelly Boothby

Description: modified (diff)

comment:2 Changed 11 years ago by Kelly Boothby

Status: newneeds_review

comment:3 Changed 11 years ago by Kelly Boothby

Description: modified (diff)
Status: needs_reviewneeds_work
Summary: Add is_monomial() to power series ring elementsAdd is_monomial() to power series and laurent series ring elements

comment:4 Changed 11 years ago by Kelly Boothby

Keywords: sd32 added

Changed 11 years ago by Kelly Boothby

Attachment: trac_11719.patch added

comment:5 Changed 11 years ago by Kelly Boothby

Status: needs_workneeds_review

comment:6 Changed 11 years ago by Kelly Boothby

Authors: Tom Boothby

comment:7 Changed 11 years ago by Kelly Boothby

Dependencies: #11726

comment:8 Changed 11 years ago by William Stein

Status: needs_reviewneeds_work

Needs work, due to #11747 -- ambiguity of is_monomial.

comment:9 Changed 9 years ago by Jeroen Demeyer

Milestone: sage-5.11sage-5.12

comment:10 Changed 9 years ago by For batch modifications

Milestone: sage-6.1sage-6.2

comment:11 Changed 9 years ago by Frédéric Chapoton

Keywords: laurent series power series added

comment:12 Changed 9 years ago by Ralf Stephan

Branch: u/rws/add_is_monomial___to_power_series_and_laurent_series_ring_elements

comment:13 Changed 9 years ago by Ralf Stephan

Authors: Tom BoothbyTom Boothby, Ralf Stephan
Commit: c3851c0f6a79d049ea5efc43a50359fe5a70ca08
Dependencies: #11726
Status: needs_workneeds_review

Rebased on 6.2.beta8. I changed the implementation of LaurentPolynomial.is_monomial because it gave the wrong (in the sense of #11747) result. It would also have marked zero as a monomial which would be wrong IMHO, and not according to Polynomial.is_monomial. I also changed the documentation to fit #11747. I removed the words non-negative from the doc of the laurent_polynomial.pyx implementation. I finally fixed appearances of "Returns".


New commits:

c3851c011719: add is_monomial to power series and Laurent poly and series

comment:14 Changed 9 years ago by For batch modifications

Milestone: sage-6.2sage-6.3

comment:15 Changed 9 years ago by Peter Bruin

Reviewers: Peter Bruin
Status: needs_reviewpositive_review

Looks good and the patchbot is happy.

comment:16 Changed 9 years ago by Volker Braun

Branch: u/rws/add_is_monomial___to_power_series_and_laurent_series_ring_elementsc3851c0f6a79d049ea5efc43a50359fe5a70ca08
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.