#11642 closed defect (fixed)
Rewrite/improve/fix SQLDatabase and SQLQuery objects
Reported by: | ohanar | Owned by: | was |
---|---|---|---|
Priority: | major | Milestone: | sage-4.7.2 |
Component: | packages: huge | Keywords: | sqlite |
Cc: | cremona, was | Merged in: | sage-4.7.2.alpha3 |
Authors: | R. Andrew Ohana | Reviewers: | Tom Boothby |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #11640 | Stopgaps: |
Description (last modified by )
Currently the SQLDatabase
object in sage has a number of bugs (adding columns to a database when initializing it, keyword parsing for the SQLQuery.show
method to name a few). There is also some missing functionality (uniqueness of non-index columns, columns of unspecified types). Also, a lot of code can be refactored/removed.
I've attached 2 patches that depend upon #11640. The is a rewrite of these objects, and moves them to sage.databases.sql_db
and the second makes the necessary changes to sage.graphs.graph_database
.
Apply
to the Sage library.
Attachments (2)
Change History (7)
Changed 11 years ago by
comment:1 Changed 11 years ago by
- Status changed from new to needs_review
Changed 11 years ago by
comment:2 Changed 11 years ago by
- Reviewers set to Tom Boothby
- Status changed from needs_review to positive_review
looks good, works good. RIP, Simon.
comment:3 Changed 11 years ago by
- Dependencies set to #11640
- Description modified (diff)
If these patches depend on #11640, then please also add that ticket to the Dependencies field.
comment:4 Changed 11 years ago by
- Merged in set to sage-4.7.2.alpha3
- Resolution set to fixed
- Status changed from positive_review to closed
comment:5 Changed 9 years ago by
Please have a look at #14477.
Updated!