Opened 11 years ago

Last modified 11 years ago

#11601 closed enhancement

Generic congruence subgroups — at Version 6

Reported by: David Loeffler Owned by: Craig Citro
Priority: major Milestone: sage-5.0
Component: modular forms Keywords: modular subgroup congruence sd35
Cc: Merged in:
Authors: David Loeffler Reviewers:
Report Upstream: N/A Work issues: docbuild
Branch: Commit:
Dependencies: #10335, #11422, #11598, #10453, #5048 Stopgaps:

Status badges

Description (last modified by Johan Bosman)

This ticket adds functionality to work with arbitrary congruence subgroups of the modular group (specified by a level N and a subgroup of the finite group SL(2, Z / N Z) ). These support all the basic functionality one would expect: computation of index, genus, elliptic points, cusps, etc. There is also a facility to compute the congruence closure of a (possibly noncongruence) subgroup.

Some "rationalisation" is also included: e.g. one can no longer create Gamma1(1) or GammaH(11, [2]), which previously existed as less-functional duplicates of SL2Z and Gamma0(11). (They previously played a role in "remembering" where certain degeneracy maps would go, but they didn't do this very well -- which was the cause of the issue at #10453 -- and the new more robust approach introduced at #10453 means we can get rid of them at last.)

Part of a series of tickets: #10335 - #11422 - #11598 - #10453 - #5048 - this one - #10546.

Apply 11601.4.patch on top of #5048.

Change History (10)

Changed 11 years ago by David Loeffler

Attachment: trac_11601-congroups.patch added

Patch against 4.7.1.alpha4 + dependencies as in ticket description

comment:1 Changed 11 years ago by David Loeffler

Status: newneeds_review

comment:2 Changed 11 years ago by David Loeffler

Description: modified (diff)

Changed 11 years ago by David Loeffler

New version rebased for 4.7.2.alpha3

comment:3 Changed 11 years ago by David Loeffler

Dependencies: #10335, #11422, #11598, #5048, #10453#10335, #11422, #11598, #10453, #5048
Description: modified (diff)

comment:4 Changed 11 years ago by Johan Bosman

Status: needs_reviewneeds_work
Work issues: rebase

I tried to apply trac_11601-congroups.2.patch to 4.8.alpha4 + #5048, but it failed.

Changed 11 years ago by Johan Bosman

Attachment: 11601.3.patch added

comment:5 Changed 11 years ago by Johan Bosman

Work issues: rebasedocbuild

I'm getting a warning when building the documentation, in is_CongruenceSubgroup in congroup_generic.py:

    Note that this may be False even if `x` really is a congruence subgroup --
    it tests whether `x` is "obviously" congruence, i.e.~whether it has a
    congruence subgroup datatype. To test whether or not an arithmetic subgroup
    of `SL(2, \ZZ)` is congruence, use the ``is_congruence()` method instead.

I guess a quote is missing at the end of is_congruence().

Changed 11 years ago by Johan Bosman

Attachment: 11601.4.patch added

comment:6 Changed 11 years ago by Johan Bosman

Description: modified (diff)
Status: needs_workpositive_review
Note: See TracTickets for help on using tickets.