Opened 10 years ago

Closed 9 years ago

#11597 closed enhancement (fixed)

Dimension of the singular set

Reported by: vbraun Owned by: AlexGhitza
Priority: major Milestone: sage-4.8
Component: algebraic geometry Keywords: toric
Cc: novoselt Merged in: sage-4.8.alpha5
Authors: Volker Braun Reviewers: Andrey Novoseltsev
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #11627 Stopgaps:

Status badges

Description (last modified by novoselt)

This patch adds a method dimension_singularities() to toric varieties that computes the dimension of the singular set. This is usually one of the first questions one has, so I find it rather convenient to have a method for it. It also adds an optional fan.is_smooth(codim=d) argument for expert use, though in practice I think its easy to get confused with dimension and codimension so I did not add a similar optional argument to toric_variety.is_smooth().

Apply:

  1. trac_11597_fan_smooth_dimension.patch
  2. trac_11597_reviewer.patch

Attachments (2)

trac_11597_reviewer.patch (3.0 KB) - added by novoselt 10 years ago.
trac_11597_fan_smooth_dimension.patch (4.3 KB) - added by vbraun 10 years ago.
Rebased patch

Download all attachments as: .zip

Change History (7)

comment:1 Changed 10 years ago by vbraun

  • Cc novoselt added
  • Status changed from new to needs_review

comment:2 Changed 10 years ago by novoselt

  • Authors set to Volker Braun
  • Description modified (diff)
  • Keywords toric added
  • Reviewers set to Andrey Novoseltsev

I've changed the documentation a little and replaced d for codimension with c as otherwise I was getting very confused thinking of d as dimension. I also switched the function to automatic caching and made it reuse codimension smoothness computation. If everything looks OK, please switch to positive review!

Changed 10 years ago by novoselt

comment:3 Changed 10 years ago by novoselt

  • Dependencies set to #11627

Fixed a conflict due to import statements changes in #11627.

Changed 10 years ago by vbraun

Rebased patch

comment:4 Changed 10 years ago by vbraun

  • Status changed from needs_review to positive_review

Positive review for the reviewer patch, totally forgot about it %-)

comment:5 Changed 9 years ago by jdemeyer

  • Merged in set to sage-4.8.alpha5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.