Changes between Initial Version and Version 2 of Ticket #11585


Ignore:
Timestamp:
07/11/11 20:24:31 (9 years ago)
Author:
rbeezer
Comment:

Looks good. Passes long tests on 4.7.1.alpha3. I've cc'ed Florent Hivert in case he wants to add anything. I've also added an "Apply" section to the description for the release manager.

Two minor formatting items need attention.

Line 2287: Trac #11585::

You need a blank line after the double-colon to make the verbatim text format properly.

You can test documentation via sage -docbuild reference html after a fresh build (sage -b) and then viewing the resulting HTML file.

Line 2299:

if module is None: module_name = '__main__'
else: module_name = module.__name__

should be formatted as

if module is None:
    module_name = '__main__'
else:
    module_name = module.__name__

See http://www.sagemath.org/doc/developer/conventions.html

which references: http://www.python.org/dev/peps/pep-0008/

(look shortly after "Compound statements")

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11585

    • Property Status changed from new to needs_work
    • Property Cc hivert added
    • Property Reviewers changed from to Rob Beezer
  • Ticket #11585 – Description

    initial v2  
    99sqrt(5)
    1010}}}
     11
     12'''Apply:'''
     13  1.  [attachment:trac_11585_depracted_function_alias.patch]
    1114
    1215which is misleading because the user would expect to find `sqrt` in the same module as `a`.