#11583 closed defect (fixed)
Sagetex example has some nontrivial dependancy's
Reported by: | mderickx | Owned by: | tbd |
---|---|---|---|
Priority: | blocker | Milestone: | sage-4.8 |
Component: | packages: standard | Keywords: | |
Cc: | ddrake, fbissey | Merged in: | sage-4.8.alpha3 |
Authors: | Maarten Derickx, Dan Drake | Reviewers: | John Palmieri |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
As mentioned in https://groups.google.com/forum/#!topic/sage-devel/6I3BD32YZWI the standard sagetex example included in sage depends on tkz-berge which can be hard to get it working correctly. This might scare of sagetex users while tkz-berge is only needed for the graph (with vertices and edges) part of sage. The new version of the example .tex disables this part of the example by default with some notice on how to enable it.
Merge the new spkg: http://sage.math.washington.edu/home/jdemeyer/spkg/sagetex-2.3.1.p1.spkg
Attachments (2)
Change History (12)
Changed 10 years ago by
comment:1 Changed 10 years ago by
- Cc ddrake added
- Type changed from PLEASE CHANGE to defect
comment:2 Changed 9 years ago by
- Priority changed from major to blocker
comment:3 Changed 9 years ago by
- Cc fbissey added
Changed 9 years ago by
Fix instructions in example.tex on new file extension (.sage -> .sagetex.sage)
comment:4 Changed 9 years ago by
Above a separate patch to fix example.sage to example.sagetex.sage in the file example.tex.
comment:5 Changed 9 years ago by
- Status changed from new to needs_review
I have an updated spkg that should fix both the file extension and tkz-berge
/TikZ problems: http://sage.math.washington.edu/home/drake/code/sage/st/sagetex-2.3.1.p1.spkg.
To fully review, you'll need to look at some revisions to the source code; start with rev 3cc4e629401e "remove \sageplot default of .75\textwidth; make the user decide": https://bitbucket.org/ddrake/sagetex/changesets and look over all the revs to the tip. (A bunch are simple one-liners; don't be discouraged.)
Then you'll need to look over the most recent two revisions to the spkg repository (inside the spkg).
Finally, install the spkg with SAGE_CHECK=yes and make sure it works.
comment:6 Changed 9 years ago by
- Reviewers set to John Palmieri
- Status changed from needs_review to positive_review
Looks good to me. Passes doctests on several different machines where it failed before, some of which have recent TeX distributions, some of which have old TeX distributions, and some of which are missing TeX altogether.
The only part of the change log that I don't completely understand (because I don't know LaTeX style files very well) is this one, but I tried putting some Sage code in a labeled math environment, like align, and it worked fine.
comment:7 Changed 9 years ago by
Please give clear instructions in the ticket description of what should be merged.
comment:8 Changed 9 years ago by
- Description modified (diff)
comment:9 Changed 9 years ago by
- Merged in set to sage-4.8.alpha3
- Resolution set to fixed
- Status changed from positive_review to closed
comment:10 Changed 9 years ago by
- Description modified (diff)
A related, but not completely identical problem: self-tests fail for the sagetex package. If I set SAGE_CHECK=yes and then do
sage -f sagetex...
, I get a message likeI know how to fix this problem, but self-tests still fail if various
.sty
files are missing, as they are on sage.math:I think the following patch fixes the first problem, but not the second:
spkg-check
package.dtxpackageI'm upgrading this to a blocker, since all of our spkg's should pass self-tests. (Well, except for Python...)