Changes between Version 168 and Version 182 of Ticket #11521


Ignore:
Timestamp:
10/05/12 22:47:51 (8 years ago)
Author:
nbruin
Comment:

OK, I've adapted two doctests to reflect that polynomial rings still are not garbage collected. Furthermore, I backported two changes from #13447:

  • A change to a doctest for modular forms spaces, which depended on previously cached computation. Since these things do get collected now, the caching was lost. The rewrite forces recomputation, so the dependence on things not getting deleted is removed
  • The ignored AttributeError (which doesn't cause a doctest failure, by the way. The warning is only visible because it happened near a doctest that failed for another reason). Since we found where this ignore was happening anyway http://trac.sagemath.org/sage_trac/ticket/13447#comment:30 we might as well fix it now. It's a side-effect of things getting collected, but the change itself doesn't depend on the proper refcounting details that #13447 itself is hanging on.

All doctests pass for me with this, so back to positive review.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11521 – Description

    v168 v182  
    2525* [attachment:trac_11521_homset_weakcache_combined.patch]
    2626* [attachment:trac_11521_callback.patch]
     27* [attachment:trac_11521_doctestfix.patch]