Changes between Version 131 and Version 149 of Ticket #11521


Ignore:
Timestamp:
08/16/12 17:52:48 (8 years ago)
Author:
SimonKing
Comment:

OK, the additional patch has been posted. It removes the explicit weak reference to the category (TripleDict uses a weak reference anyway), adds a callback to the weak reference to the homset, so that an item of the homset cache gets deleted if the homset is garbage collected, and it replaces "if H:" by "if H is not None:".

I doctested sage/schemes/ (heuristics: Most bugs I ever authored resulted in a segfault in sage/schemes :), sage/structure/ and sage/categories/homset.py (hence, the memory leak remains fixed).

Apply #715 trac_11521_homset_weakcache_combined.patch trac_11521_callback.patch

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11521

    • Property Status changed from positive_review to needs_review
    • Property Dependencies changed from #11900 #715 to #12969; to be merged with #715
    • Property Milestone changed from sage-pending to sage-5.2
  • Ticket #11521 – Description

    v131 v149  
    2424* the patches from #715
    2525* [attachment:trac_11521_homset_weakcache_combined.patch]
     26* [attachment:trac_11521_callback.patch]