Opened 11 years ago

Closed 11 years ago

#11499 closed defect (fixed)

Sage library fails to build on Cygwin

Reported by: Karl-Dieter Crisman Owned by: tbd
Priority: major Milestone: sage-4.7.2
Component: porting: Cygwin Keywords:
Cc: Mike Hansen, Dima Pasechnik, William Stein Merged in: sage-4.7.2.alpha2
Authors: Karl-Dieter Crisman Reviewers: Reg Burgess
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Karl-Dieter Crisman)

The file sage/rings/factorint.pyx needs to add libraries=['gmp'] as a dependency now.

Attachments (1)

trac_11499.patch (751 bytes) - added by Karl-Dieter Crisman 11 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 11 years ago by Karl-Dieter Crisman

Description: modified (diff)

comment:2 Changed 11 years ago by Karl-Dieter Crisman

Authors: Karl-Dieter Crisman
Description: modified (diff)

comment:3 Changed 11 years ago by Karl-Dieter Crisman

This apparently still isn't quite the right fix.

Changed 11 years ago by Karl-Dieter Crisman

Attachment: trac_11499.patch added

comment:4 Changed 11 years ago by Karl-Dieter Crisman

Description: modified (diff)
Status: newneeds_review

comment:5 Changed 11 years ago by Karl-Dieter Crisman

This needs review. Given the troubles building on Win7, checking that this doesn't break our 'normal' builds and one other person checking on XP should be sufficient to review.

comment:6 Changed 11 years ago by Karl-Dieter Crisman

Cc: Dima Pasechnik added; pasechnik removed

comment:7 Changed 11 years ago by Karl-Dieter Crisman

I've now checked this a number of times on Cygwin in the course of building Sage. It would be really nice for someone to make sure this doesn't break anything on 'normal' systems, and hopefully to check it on at least one Windows box - if only so that I don't have to manually fix it whenever I get to the middle of building the Sage spkg!

comment:8 Changed 11 years ago by Karl-Dieter Crisman

User "RegB" was able to use this successfully for this - see this sage-windows thread.

So this should have positive review. Hopefully I can get a "real" name for this person.

comment:9 Changed 11 years ago by Karl-Dieter Crisman

Reviewers: Reg Burgess
Status: needs_reviewpositive_review

Reg confirmed this attribution by real name was ok in a private email. Welcome to the Sage community, Reg!

comment:10 Changed 11 years ago by Jeroen Demeyer

Milestone: sage-4.7.1sage-4.7.2

comment:11 Changed 11 years ago by Jeroen Demeyer

Merged in: sage-4.7.2.alpha2
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.