Opened 11 years ago

Closed 9 years ago

#11492 closed defect (wontfix)

Do not modify permissions on vcs-tracked scripts in sage-make_devel_packages

Reported by: kini Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: scripts Keywords:
Cc: jdemeyer, iandrus Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

As above. Mercurial tracks file permissions, so there is no reason to modify them after unpacking them, as is done in lines 139-141 of $SAGE_LOCAL/sage-make_devel_packages. Right?

Continued from #11449.

Apply:

  1. 11492_root_perm.patch​ to SAGE_ROOT
  2. 11492_scripts_perm.patch​ to SAGE_LOCAL/bin

Attachments (2)

11492_root_perm.patch​ (1.4 KB) - added by jdemeyer 9 years ago.
11492_scripts_perm.patch​ (2.6 KB) - added by jdemeyer 9 years ago.

Download all attachments as: .zip

Change History (9)

Changed 9 years ago by jdemeyer

Changed 9 years ago by jdemeyer

comment:1 Changed 9 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Status changed from new to needs_review

comment:2 Changed 9 years ago by jdemeyer

  • Description modified (diff)

comment:3 Changed 9 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:4 Changed 9 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:5 Changed 9 years ago by mmezzarobba

  • Authors Jeroen Demeyer deleted
  • Milestone changed from sage-6.2 to sage-duplicate/invalid/wontfix

make_devel_package disappeared with the switch to git (commit 48ff645017639d70d9b4a7107ac7fd98d8a871b5).

comment:6 Changed 9 years ago by aapitzsch

  • Status changed from needs_review to positive_review

comment:7 Changed 9 years ago by vbraun

  • Resolution set to wontfix
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.