Opened 9 years ago

Closed 9 years ago

#11489 closed enhancement (fixed)

iframe command

Reported by: bic Owned by: jason, mpatel, was
Priority: major Milestone: sage-4.7.2
Component: notebook Keywords: geogebra sd31
Cc: kini, rbeezer Merged in: sage-4.7.2.alpha1
Authors: Bruce Cohen Reviewers: Keshav Kini, Ryan Grout
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

The html <iframe> tag is a quick way to embed a web page into Sage. A new python function iframe(url) would make it easier (and cleaner) to bring existing web pages into a Sage notebook. This started as a way to bring GeoGebra worksheets into Sage, but in fact it could be used for other web based software.

See examples.

Apply trac_11489-iframe.reviewer.reviewer.patch

Attachments (3)

trac11489_iframe.patch (2.1 KB) - added by bic 9 years ago.
trac_11489-iframe.reviewer.patch (3.8 KB) - added by kini 9 years ago.
trac_11489-iframe.reviewer.reviewer.patch (3.0 KB) - added by ryan 9 years ago.
only apply this patch

Download all attachments as: .zip

Change History (17)

comment:1 Changed 9 years ago by bic

  • Keywords sd31 added

comment:2 Changed 9 years ago by kini

  • Authors Bruce Cohen deleted
  • Cc kini added
  • Description modified (diff)
  • Keywords changed from geogebra, sd31 to geogebra sd31

(the Author field is to document who has written a patch, and there is no patch yet)

Changed 9 years ago by bic

comment:3 Changed 9 years ago by bic

  • Authors set to Bruce Cohen
  • Status changed from new to needs_review

comment:4 Changed 9 years ago by bic

  • Cc rbeezer added

comment:5 Changed 9 years ago by kini

Here's a reviewer patch to fix some minor things. Looks good, passes doctests.

Changed 9 years ago by kini

comment:6 Changed 9 years ago by kini

  • Reviewers set to Keshav Kini

comment:7 Changed 9 years ago by bic

  • Description modified (diff)

comment:8 Changed 9 years ago by kini

  • Description modified (diff)

Changed 9 years ago by ryan

only apply this patch

comment:9 Changed 9 years ago by ryan

  • Reviewers changed from Keshav Kini to Keshav Kini, Ryan Grout
  • Status changed from needs_review to positive_review

combined the two patches into trac_11489-iframe.reviewer.reviewer.patch. Also changed docstring to be a rawstring. Tests pass, and functions correctly and code looks good. Positive Review.

comment:10 Changed 9 years ago by ryan

  • Description modified (diff)

comment:11 Changed 9 years ago by kini

I'm not sure it was really necessary to combine the patches, but OK :) Thanks for the review! For future reference, you should generally use the more complete "git format" patches - put this in your ~/.hgrc to enable them:

[diff]
git = yes

comment:12 Changed 9 years ago by jdemeyer

  • Description modified (diff)

comment:13 Changed 9 years ago by jdemeyer

  • Milestone changed from sage-4.7.1 to sage-4.7.2

comment:14 Changed 9 years ago by jdemeyer

  • Merged in set to sage-4.7.2.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.